[Kimchi-devel] [PATCH] [Wok] Added new Wok logo and script to display installed plugins icons

Aline Manera alinefm at linux.vnet.ibm.com
Fri Feb 26 15:49:16 UTC 2016


After getting the logos for Kimchi, Ginger and Ginger Base (from the 
ML), I have some more comments:

* IMO the plugins logos should have the same size as wok logo (they are 
too big for me)
Also they should be aligned in one line and only be displayed in 
multiples lines for small screens,




* The footbar does not display the plugins logos and Firebug report 2 
errors (see below)


On 02/25/2016 05:46 PM, Aline Manera wrote:
> Hi Samuel,
>
> I have 2 comments:
>
> 1) Make the "Wok" title bold
>
> 2) Do not display the "Powered By:" label when no plugin logo is found
>
> Regards,
> Aline Manera
>
> On 02/25/2016 03:51 PM, sguimaraes943 at gmail.com wrote:
>> From: Samuel Guimarães <sguimaraes943 at gmail.com>
>>
>> This patch replaces the old Kimchi logo in Wok with the new Wok logo, 
>> following other image assets like iOS, Android and Windows 8/8.1/10 
>> application bookmark icons and Safari pinnable bookmark/panel icon.
>> It also comes with a new script that checks the installed plugins as 
>> well as their versions and if a *.svg or *.png file with the plugin 
>> name in ui/images/ is found, the script will append a list with the 
>> logos in the desired element.
>>
>> Samuel Guimarães (1):
>>    Added new Wok logo and script to display installed plugins icons and
>>      versions
>>
>>   ui/css/bootstrap.custom.css                |   2 +-
>>   ui/css/src/modules/_about.scss             |  41 +++++++-
>>   ui/css/src/modules/_animation.scss         |  18 +++-
>>   ui/css/src/modules/_login.scss             |  48 +++++++++
>>   ui/css/src/modules/_navbar-flat.scss       |   2 +-
>>   ui/css/src/modules/_wok-variables.scss     |   2 +-
>>   ui/css/src/wok.scss                        |  58 +++++++++++
>>   ui/css/wok.css                             | 161 
>> ++++++++++++++++++++++++++++-
>>   ui/images/Makefile.am                      |   2 +-
>>   ui/images/android-chrome-144x144.png       | Bin 0 -> 742 bytes
>>   ui/images/android-chrome-192x192.png       | Bin 3508 -> 851 bytes
>>   ui/images/android-chrome-36x36.png         | Bin 0 -> 391 bytes
>>   ui/images/android-chrome-48x48.png         | Bin 0 -> 443 bytes
>>   ui/images/android-chrome-72x72.png         | Bin 0 -> 538 bytes
>>   ui/images/android-chrome-96x96.png         | Bin 0 -> 585 bytes
>>   ui/images/apple-touch-icon-114.png         | Bin 2360 -> 0 bytes
>>   ui/images/apple-touch-icon-114x114.png     | Bin 0 -> 561 bytes
>>   ui/images/apple-touch-icon-120.png         | Bin 2382 -> 0 bytes
>>   ui/images/apple-touch-icon-120x120.png     | Bin 0 -> 600 bytes
>>   ui/images/apple-touch-icon-144.png         | Bin 2758 -> 0 bytes
>>   ui/images/apple-touch-icon-144x144.png     | Bin 0 -> 674 bytes
>>   ui/images/apple-touch-icon-152.png         | Bin 2962 -> 0 bytes
>>   ui/images/apple-touch-icon-152x152.png     | Bin 0 -> 757 bytes
>>   ui/images/apple-touch-icon-180.png         | Bin 3404 -> 0 bytes
>>   ui/images/apple-touch-icon-180x180.png     | Bin 0 -> 786 bytes
>>   ui/images/apple-touch-icon-57.png          | Bin 1449 -> 0 bytes
>>   ui/images/apple-touch-icon-57x57.png       | Bin 0 -> 469 bytes
>>   ui/images/apple-touch-icon-60.png          | Bin 1476 -> 0 bytes
>>   ui/images/apple-touch-icon-60x60.png       | Bin 0 -> 462 bytes
>>   ui/images/apple-touch-icon-72.png          | Bin 1718 -> 0 bytes
>>   ui/images/apple-touch-icon-72x72.png       | Bin 0 -> 516 bytes
>>   ui/images/apple-touch-icon-76.png          | Bin 1734 -> 0 bytes
>>   ui/images/apple-touch-icon-76x76.png       | Bin 0 -> 532 bytes
>>   ui/images/apple-touch-icon-precomposed.png | Bin 3673 -> 1139 bytes
>>   ui/images/apple-touch-icon.png             | Bin 3404 -> 786 bytes
>>   ui/images/favicon-16x16.png                | Bin 0 -> 622 bytes
>>   ui/images/favicon-194x194.png              | Bin 0 -> 1868 bytes
>>   ui/images/favicon-32x32.png                | Bin 0 -> 755 bytes
>>   ui/images/favicon-96x96.png                | Bin 0 -> 1248 bytes
>>   ui/images/favicon.ico                      | Bin 15086 -> 15086 bytes
>>   ui/images/favicon.png                      | Bin 17356 -> 1868 bytes
>>   ui/images/large.png                        | Bin 36434 -> 0 bytes
>>   ui/images/mstile-144x144.png               | Bin 0 -> 712 bytes
>>   ui/images/mstile-150x150.png               | Bin 0 -> 705 bytes
>>   ui/images/mstile-310x150.png               | Bin 0 -> 729 bytes
>>   ui/images/mstile-310x310.png               | Bin 0 -> 1067 bytes
>>   ui/images/mstile-70x70.png                 | Bin 0 -> 601 bytes
>>   ui/images/safari-pinned-tab.svg            |  19 ++++
>>   ui/images/square.png                       | Bin 15679 -> 0 bytes
>>   ui/images/theme-default/logo-white.png     | Bin 7583 -> 3229 bytes
>>   ui/images/tiny.png                         | Bin 6539 -> 0 bytes
>>   ui/images/wide.png                         | Bin 44544 -> 0 bytes
>>   ui/images/wok-logo.png                     | Bin 0 -> 3229 bytes
>>   ui/images/wok.png                          | Bin 0 -> 3327 bytes
>>   ui/images/wok.svg                          |  45 ++++++++
>>   ui/js/src/wok.login.js                     |   2 +
>>   ui/js/src/wok.logos.js                     | 102 ++++++++++++++++++
>>   ui/js/src/wok.main.js                      |   2 +
>>   ui/pages/login.html.tmpl                   | 120 +++++++++++----------
>>   ui/pages/wok-ui.html.tmpl                  |  67 ++++++++----
>>   60 files changed, 602 insertions(+), 89 deletions(-)
>>   create mode 100644 ui/images/android-chrome-144x144.png
>>   create mode 100644 ui/images/android-chrome-36x36.png
>>   create mode 100644 ui/images/android-chrome-48x48.png
>>   create mode 100644 ui/images/android-chrome-72x72.png
>>   create mode 100644 ui/images/android-chrome-96x96.png
>>   delete mode 100644 ui/images/apple-touch-icon-114.png
>>   create mode 100644 ui/images/apple-touch-icon-114x114.png
>>   delete mode 100644 ui/images/apple-touch-icon-120.png
>>   create mode 100644 ui/images/apple-touch-icon-120x120.png
>>   delete mode 100644 ui/images/apple-touch-icon-144.png
>>   create mode 100644 ui/images/apple-touch-icon-144x144.png
>>   delete mode 100644 ui/images/apple-touch-icon-152.png
>>   create mode 100644 ui/images/apple-touch-icon-152x152.png
>>   delete mode 100644 ui/images/apple-touch-icon-180.png
>>   create mode 100644 ui/images/apple-touch-icon-180x180.png
>>   delete mode 100644 ui/images/apple-touch-icon-57.png
>>   create mode 100644 ui/images/apple-touch-icon-57x57.png
>>   delete mode 100644 ui/images/apple-touch-icon-60.png
>>   create mode 100644 ui/images/apple-touch-icon-60x60.png
>>   delete mode 100644 ui/images/apple-touch-icon-72.png
>>   create mode 100644 ui/images/apple-touch-icon-72x72.png
>>   delete mode 100644 ui/images/apple-touch-icon-76.png
>>   create mode 100644 ui/images/apple-touch-icon-76x76.png
>>   create mode 100644 ui/images/favicon-16x16.png
>>   create mode 100644 ui/images/favicon-194x194.png
>>   create mode 100644 ui/images/favicon-32x32.png
>>   create mode 100644 ui/images/favicon-96x96.png
>>   delete mode 100644 ui/images/large.png
>>   create mode 100644 ui/images/mstile-144x144.png
>>   create mode 100644 ui/images/mstile-150x150.png
>>   create mode 100644 ui/images/mstile-310x150.png
>>   create mode 100644 ui/images/mstile-310x310.png
>>   create mode 100644 ui/images/mstile-70x70.png
>>   create mode 100644 ui/images/safari-pinned-tab.svg
>>   delete mode 100644 ui/images/square.png
>>   delete mode 100644 ui/images/tiny.png
>>   delete mode 100644 ui/images/wide.png
>>   create mode 100644 ui/images/wok-logo.png
>>   create mode 100644 ui/images/wok.png
>>   create mode 100644 ui/images/wok.svg
>>   create mode 100644 ui/js/src/wok.logos.js
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20160226/d95aa4db/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: didhghbf.
Type: image/jpeg
Size: 32131 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20160226/d95aa4db/attachment.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: idadbbca.
Type: image/jpeg
Size: 19727 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20160226/d95aa4db/attachment-0001.jpe>


More information about the Kimchi-devel mailing list