[Kimchi-devel] [PATCH][wok] Limit number of log files kept in the system to 10

Rodrigo Trujillo rodrigo.trujillo at linux.vnet.ibm.com
Wed Jan 13 10:20:35 UTC 2016


Thanks for the review Paulo, but I am going to send a version 2 that is 
going to allow user to modify this property.

Rodrigo

On 01/12/2016 02:11 PM, Paulo Vital wrote:
>
> Reviewed-by: Paulo Vital <pvital at linux.vnet.ibm.com>
>
>
> On 01/12/2016 02:04 PM, Rodrigo Trujillo wrote:
>> Currently Wok is configured to keep up to 1000 log files of 10MB, this
>> behavior makes Wok/Kimchi log space become huge (up to 20GB, for error
>> and access logs).
>> This patch changes the configuration, limiting the number of stored log
>> files to 10. So space required in the system will be up to 200MB.
>>
>> Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo at linux.vnet.ibm.com>
>> ---
>>   src/wok/server.py | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/wok/server.py b/src/wok/server.py
>> index 59ecdc0..8ac67a1 100644
>> --- a/src/wok/server.py
>> +++ b/src/wok/server.py
>> @@ -101,7 +101,7 @@ class Server(object):
>>
>>           # Create handler to rotate access log file
>>           h = logging.handlers.RotatingFileHandler(options.access_log, 'a',
>> -                                                 10000000, 1000)
>> +                                                 10000000, 10)
>>           h.setLevel(logLevel)
>>           h.setFormatter(cherrypy._cplogging.logfmt)
>>
>> @@ -110,7 +110,7 @@ class Server(object):
>>
>>           # Create handler to rotate error log file
>>           h = logging.handlers.RotatingFileHandler(options.error_log, 'a',
>> -                                                 10000000, 1000)
>> +                                                 10000000, 10)
>>           h.setLevel(logLevel)
>>           h.setFormatter(cherrypy._cplogging.logfmt)
>>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>




More information about the Kimchi-devel mailing list