[Kimchi-devel] [PATCH v2][Kimchi 0/6] Make Kimchi able to change guest's boot order

Daniel Henrique Barboza dhbarboza82 at gmail.com
Wed Jul 13 15:29:23 UTC 2016


This test is failing with this patch set:

[danielhb at arthas tests]$ sudo ./run_tests.sh 
test_model.ModelTests.test_vm_info
***** Running unit test: test_model.ModelTests.test_vm_info...  FAILED
======================================================================
FAIL: test_vm_info (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "test_model.py", line 127, in test_vm_info
     self.assertEquals(keys, set(info.keys()))
AssertionError: Items in the second set but not the first:
'bootorder'

----------------------------------------------------------------------
Ran 1 test in 0.770s

FAILED (failures=1)
======================================================================
===================== Kimchi Unit Tests Summary ======================
Ran 1 tests in .770 seconds.
test_model.ModelTests.test_vm_info FAILED: (failures=1) - full log 
available at /tmp/tmp.lwhN2tgs0h
[danielhb at arthas tests]$


Same test works in master:



[danielhb at arthas tests]$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
[danielhb at arthas tests]$ sudo ./run_tests.sh 
test_model.ModelTests.test_vm_info
***** Running unit test: test_model.ModelTests.test_vm_info...  PASSED - 
Ran 1 test in 0.735s
======================================================================
===================== Kimchi Unit Tests Summary ======================
Ran 1 tests in .735 seconds.
[danielhb at arthas tests]$


On 07/11/2016 10:05 AM, Ramon Medeiros wrote:
> Changes:
>
> v2:
> Do not manipulate xml on model
> Improve parameters checking at API.json
> Increase test cases
>
> Ramon Medeiros (6):
>    Add function get_bootorder_node
>    Create method to change bootorder of a guest
>    Update documentation about bootorder on vm update
>    Update REST API
>    Add function to retrieve bootorder on vm lookup
>    Add test to check bootorder
>
>   API.json              | 23 +++++++++++++++++++++++
>   docs/API.md           |  1 +
>   i18n.py               |  1 +
>   model/vms.py          | 32 ++++++++++++++++++++++++++++++--
>   tests/test_model.py   | 13 +++++++++++++
>   xmlutils/bootorder.py | 19 +++++++++++++------
>   6 files changed, 81 insertions(+), 8 deletions(-)
>




More information about the Kimchi-devel mailing list