[Kimchi-devel] [PATCH][Kimchi 0/2] Issue #467: Feature: Show boot menu for a guest

[Aline Manera]

Hi Ramon,

The overall patch looks good for me.

Just some clarification:

1. I noticed you add the capabilities to *edit* the guest to change the 
boot menu option. What about the default behavior?

2. What about when creating a guest from scratch?

3. Shouldn't I change that configuration in a Template to reflect N 
guests I will create from it?

Regards,
Aline Manera

On 07/13/2016 10:25 PM, Ramon Medeiros wrote:
> based on "Make Kimchi able to change guest's boot order"
>
> Ramon Medeiros (2):
>    Allow guest to enable bootmenu on startup
>    Add test to verify bootmenu and update old tests
>
>   API.json                |  5 +++++
>   docs/API.md             |  1 +
>   i18n.py                 |  1 +
>   model/vms.py            | 30 +++++++++++++++++++++---------
>   tests/test_mockmodel.py |  2 +-
>   tests/test_model.py     |  8 +++++++-
>   xmlutils/bootorder.py   |  3 +++
>   7 files changed, 39 insertions(+), 11 deletions(-)
>