[Kimchi-devel] [PATCH][Kimchi 0/2] Issue #467: Feature: Show boot menu for a guest

[Aline Manera]

On 07/21/2016 03:28 PM, Ramon Medeiros wrote:
>
>
> On 07/21/2016 02:49 PM, Aline Manera wrote:
>> Hi Ramon,
>>
>> The overall patch looks good for me.
>>
>> Just some clarification:
>>
>> 1. I noticed you add the capabilities to *edit* the guest to change 
>> the boot menu option. What about the default behavior?
>>
>> 2. What about when creating a guest from scratch?
>>
>> 3. Shouldn't I change that configuration in a Template to reflect N 
>> guests I will create from it?
>
> The point about using bootmenu on guest, i don't know a use case for 
> it. For me, bootmenu it's something that we will use on very specific 
> cases, not sure if it's needed all the time (like recover partitions).
>
> What do you think?

So is your proposal to do not enable bootmenu by default? (Is it related 
to the Item 1. I mentioned above?)
If it is that what you are proposing, I am ok with that.

Do you have any comments about Item 2. and 3. ?

>>
>> Regards,
>> Aline Manera
>>
>> On 07/13/2016 10:25 PM, Ramon Medeiros wrote:
>>> based on "Make Kimchi able to change guest's boot order"
>>>
>>> Ramon Medeiros (2):
>>>    Allow guest to enable bootmenu on startup
>>>    Add test to verify bootmenu and update old tests
>>>
>>>   API.json                |  5 +++++
>>>   docs/API.md             |  1 +
>>>   i18n.py                 |  1 +
>>>   model/vms.py            | 30 +++++++++++++++++++++---------
>>>   tests/test_mockmodel.py |  2 +-
>>>   tests/test_model.py     |  8 +++++++-
>>>   xmlutils/bootorder.py   |  3 +++
>>>   7 files changed, 39 insertions(+), 11 deletions(-)
>>>
>>
>