[Kimchi-devel] [PATCH] [Wok] Fix for filter break for numbers formatted for locale fr-FR

Pooja Kulkarni pkulkark at linux.vnet.ibm.com
Mon Jun 13 09:26:56 UTC 2016


Hi Aline,

Can this patch be merged?

On 05/30/2016 05:37 PM, Archana Singh wrote:
> Reviewed-By: Archana Singh <archus at linux.vent.ibm.com>
>
> On 5/26/2016 1:49 PM, pkulkark at linux.vnet.ibm.com wrote:
>> From: Pooja Kulkarni <pkulkark at linux.vnet.ibm.com>
>>
>> This patch fixes the filter breaking
>> issue on numbers formatted as per
>> fr-FR locale, by replacing the
>> non-breaking spaces introduced by
>> the formatting, with breaking spaces.
>>
>> Signed-off-by: Pooja Kulkarni <pkulkark at linux.vnet.ibm.com>
>> ---
>>   ui/js/src/wok.utils.js | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/ui/js/src/wok.utils.js b/ui/js/src/wok.utils.js
>> index 1fb3c9b..76477fd 100644
>> --- a/ui/js/src/wok.utils.js
>> +++ b/ui/js/src/wok.utils.js
>> @@ -263,7 +263,11 @@ wok.localeConverters = {
>>          },
>>          "number-locale-converter":{
>>              to: function(number){
>> -              return wok.numberLocaleConverter(number, 
>> wok.lang.get_locale());
>> +              if (number == null) {
>> +                 return 'Unknown';
>> +              }
>> +              format_value = wok.numberLocaleConverter(number, 
>> wok.lang.get_locale());
>> +              return format_value.toString().replace(/\s/g,' '); 
>> //replace non-breaking space with breaking space
>>              }
>>         }
>>   }
>




More information about the Kimchi-devel mailing list