[Kimchi-devel] [PATCH V2] [Wok 0/6] Log failed user requests

[Aline Manera]

Hi Lucio,

I cleaned up wok-req.log and the tests passed! =)
Sorry about the noise.

Regards,
Aline Manera

On 06/21/2016 05:05 PM, Aline Manera wrote:
>
> Some tests cases are failing:
>
> ......
> ======================================================================
> FAIL: test_user_log (test_api.APITests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "test_api.py", line 88, in test_user_log
>     self.assertEquals(sorted(keys), sorted(record.keys()))
> AssertionError: Lists differ: [u'app', u'date', u'ip', u'mes... != 
> [u'app', u'date', u'ip', u'mes...
>
> First differing element 5:
> status
> time
>
> First list contains 1 additional elements.
> First extra element 8:
> zone
>
> + [u'app', u'date', u'ip', u'message', u'req', u'time', u'user', u'zone']
> - [u'app',
> -  u'date',
> -  u'ip',
> -  u'message',
> -  u'req',
> -  u'status',
> -  u'time',
> -  u'user',
> -  u'zone']
>
> ----------------------------------------------------------------------
> Ran 28 tests in 10.319s
>
> FAILED (failures=1, skipped=2)
>
>
> On 06/09/2016 05:59 PM, Lucio Correia wrote:
>> Important:
>> * This patchset depends on [PATCH V2] [Wok 0/3] User Request Log 
>> improvements.
>> * This patch requires "[Kimchi] Do not break the logging of failed 
>> requests".
>> Otherwise, some tests will be broken.
>>
>> Changes in V2:
>> * Applied review suggestions
>>
>> Lucio Correia (6):
>>    Revert "Use past verbs"
>>    Parse request before authorization check
>>    Use status code 200 for PUT requests on resource
>>    Log failed login/logout attempts
>>    Log failed user requests
>>    Add status code to request log message
>>
>>   docs/API/logs.md        |   1 +
>>   src/wok/control/base.py | 130 
>> ++++++++++++++++++++++--------------------------
>>   src/wok/exception.py    |  28 ++++++++---
>>   src/wok/i18n.py         |   4 +-
>>   src/wok/reqlogger.py    |  10 ++--
>>   src/wok/root.py         |  44 +++++++++++-----
>>   tests/test_api.py       |   2 +-
>>   7 files changed, 122 insertions(+), 97 deletions(-)
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>