[Kimchi-devel] [PATCH v4][Kimchi 0/4] Use a single field to create a template

Paulo Ricardo Paz Vital pvital at linux.vnet.ibm.com
Thu Mar 31 15:10:57 UTC 2016


Reviewed-by: Paulo Vital <pvital at linux.vnet.ibm.com>

On Mar 31 10:47AM, Ramon Medeiros wrote:
> Instead of specify if the media is cdrom or disk, use source_media to create a template
> 
> Changes:
> 
> v2:
> Remove libvirt connection from VMtemplate
> Fix incorrect changes on tests
> Fix return status when source_media not passed
> 
> v3:
> Fix pep8 issues
> Remove/add some constants
> Rewrite API message
> 
> 
> Ramon Medeiros (4):
>   Create a single field to pass the installation media
>   Fix checking duplicate template before creating it
>   Identify installation media while creating template
>   Update tests
> 
>  API.json                    |   5 ++
>  i18n.py                     |   2 +-
>  model/templates.py          |  15 ++++--
>  tests/test_authorization.py |   4 +-
>  tests/test_livemigration.py |   7 +--
>  tests/test_mockmodel.py     |  13 +++---
>  tests/test_model.py         |  94 ++++++++++++++++++++-----------------
>  tests/test_rest.py          |  36 +++++++--------
>  tests/test_template.py      |  47 +++++++++----------
>  tests/test_vmtemplate.py    |  40 ++++++++--------
>  vmtemplate.py               | 110 +++++++++++++++++++++++++++++++++++++-------
>  11 files changed, 235 insertions(+), 138 deletions(-)
> 
> -- 
> 2.5.5
> 
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
> 




More information about the Kimchi-devel mailing list