[Kimchi-devel] [PATCH v2] [Kimchi] [RFC] Storage Volume management UI

Aline Manera alinefm at linux.vnet.ibm.com
Fri May 20 20:51:52 UTC 2016


Hi Samuel,

Some comments,

1. Use MB to resize the volume. Bytes is to difficult to deal with. =)

2. When you do an action in a volume, the volume area gets smaller and 
all volumes disappears for a second and then the volume area is rebuild 
with the new data to get back to the original size.
     Is there a way to do not change the volume size in that process? 
Maybe add a loading icon to the affected volume, get the response from 
server and only update this entry? I think that would be better from a 
user perspective.

What do you think about that?

Regards,
Aline Manera


On 05/19/2016 06:43 PM, sguimaraes943 at gmail.com wrote:
> From: Samuel Guimarães <sguimaraes943 at gmail.com>
>
> This patch adds the UI for Storage Volume management action button, filter input, gallery view and gallery / list view toggle-switch button with multi-selection enabled.
>
> v1:
>   - HTML and CSS
>
> v2:
>   - Delete and Wipe with multi-selection
>   - Confirm messages with list of selected volumes when wiping or deleting volumes (requires SCSS/CSS patch sent to Wok)
>   - Filter working
>   - Removed "Add Volume" link from Storage Pool action button
>   - Added "Add Volume" to Volume box action button
>
> To do:
>   - Clone function
>   - Fix progress bar (gallery view) and spinner (list view) when adding and cloning a new volume
>   - Add a temporary volume when cloning process is still in progress
>
> Known issues:
>   - List doesn't refresh when the only volume available is deleted from Storage Pool.
>
> Please let me know if you find any bug or if you have any suggestion.
>
> Samuel Guimarães (1):
>    Storage Volume management UI
>
>   ui/css/kimchi.css                                  | 273 +++++++++++++++----
>   ui/css/src/modules/_storage.scss                   | 295 +++++++++++++++++----
>   ui/js/src/kimchi.api.js                            |  50 ++++
>   ui/js/src/kimchi.storage_main.js                   | 256 ++++++++++++++----
>   ui/js/src/kimchi.storagepool_add_volume_main.js    |   2 +-
>   ui/js/src/kimchi.storagepool_resize_volume_main.js |  58 ++++
>   ui/pages/i18n.json.tmpl                            |   5 +
>   ui/pages/storagepool-resize-volume.html.tmpl       |  51 ++++
>   ui/pages/tabs/storage.html.tmpl                    | 120 ++++++---
>   9 files changed, 925 insertions(+), 185 deletions(-)
>   create mode 100644 ui/js/src/kimchi.storagepool_resize_volume_main.js
>   create mode 100644 ui/pages/storagepool-resize-volume.html.tmpl
>




More information about the Kimchi-devel mailing list