[Kimchi-devel] [PATCH] [WoK] Removing sessionStorage call in wok.main.js

dhbarboza82 at gmail.com dhbarboza82 at gmail.com
Thu Mar 23 12:34:51 UTC 2017


From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>

sessionStorage was being used in early versions of the websocket
notifications implementation to avoid opening multiple connections,
before the current single permanent connection approach was
implemented. If the 'wokNotificationWebSocket' key existed in the
sessionStorage, we skipped the opening of a new websocket.

This patch removes the sessionStorage usage because it accomplishes
nothing in current code. No verification is made using the created
'wokNotificationWebSocket' session key in the code.

Signed-off-by: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>
---
 ui/js/src/wok.main.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/js/src/wok.main.js b/ui/js/src/wok.main.js
index 26dc723..411b05e 100644
--- a/ui/js/src/wok.main.js
+++ b/ui/js/src/wok.main.js
@@ -69,7 +69,6 @@ wok.startNotificationWebSocket = function () {
         }
     };
 
-    sessionStorage.setItem('wokNotificationWebSocket', 'true');
     var heartbeat = setInterval(function() {
         wok.notificationsWebSocket.send(window.btoa('heartbeat'));
     }, 30000);
-- 
2.9.3



More information about the Kimchi-devel mailing list