From j.orponen at 4teamwork.ch  Tue Apr  3 09:12:41 2018
From: j.orponen at 4teamwork.ch (Joni Orponen)
Date: Tue, 3 Apr 2018 11:12:41 +0200
Subject: [Kimchi-devel] [PATCH] [Kimchi 0/3] Integrating with
	spice-web-client
In-Reply-To: <CAFNo1znm_A8kvAvwfxpcEKD=96_yNUYTF-bQm=ZQffYBequQBg@mail.gmail.com>
References: <1515815866-6549-1-git-send-email-pgurenko@gmail.com>
	<CA+jM7rhJ9-2PdnJTPC_+1+1iWE6-T6kSogwXaCie3E5_6XtVFQ@mail.gmail.com>
	<CAFNo1znm_A8kvAvwfxpcEKD=96_yNUYTF-bQm=ZQffYBequQBg@mail.gmail.com>
Message-ID: <CA+LW3i0cVW3VhZxQPSbv9PoYaODmk_tkyy53xWBQjGeZxCAkQA@mail.gmail.com>

On Wed, Mar 28, 2018 at 8:57 PM, Pavel Gurenko <pgurenko at gmail.com> wrote:

> The spice-html5 does not support the qxl drivers for Windows VMs and it
> looks like qxl has the best performance for now.
> While spice-html5 is more like proof-of-concept, a bit slow and in general
> not really supported right now.
>
> On the other hand, spice-web-client is performant, production solution and
> supports almost everything the spice can support.
>
> The pull request is mostly the drop-in replacement, spice-html5 web client
> JavaScript gets replaced with spice-web-client JavaScript.
> I used the latest version of spice-web-client from github:
> https://github.com/eyeos/spice-web-client - unfortunately guys don't have
> releases in CDN.
>

Would this also get rid of mouse acceleration mismatch issues with Windows
clients?

-- 
Joni Orponen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20180403/b715fa45/attachment.html>

From pgurenko at gmail.com  Tue Apr  3 15:46:41 2018
From: pgurenko at gmail.com (Pavel Gurenko)
Date: Tue, 03 Apr 2018 15:46:41 +0000
Subject: [Kimchi-devel] [PATCH] [Kimchi 0/3] Integrating with
	spice-web-client
In-Reply-To: <CA+LW3i0cVW3VhZxQPSbv9PoYaODmk_tkyy53xWBQjGeZxCAkQA@mail.gmail.com>
References: <1515815866-6549-1-git-send-email-pgurenko@gmail.com>
	<CA+jM7rhJ9-2PdnJTPC_+1+1iWE6-T6kSogwXaCie3E5_6XtVFQ@mail.gmail.com>
	<CAFNo1znm_A8kvAvwfxpcEKD=96_yNUYTF-bQm=ZQffYBequQBg@mail.gmail.com>
	<CA+LW3i0cVW3VhZxQPSbv9PoYaODmk_tkyy53xWBQjGeZxCAkQA@mail.gmail.com>
Message-ID: <CAFNo1zm86ydX7FSas79_v9R-cxmaPj++ke-uStXoA=ys4FB5aQ@mail.gmail.com>

If you mean the ones before installing spice guest tools (two cursors),
then no, I guess it's not.
I had no issues with spice guest tools installed.

On Tue, Apr 3, 2018, 2:13 AM Joni Orponen <j.orponen at 4teamwork.ch> wrote:

> On Wed, Mar 28, 2018 at 8:57 PM, Pavel Gurenko <pgurenko at gmail.com> wrote:
>
>> The spice-html5 does not support the qxl drivers for Windows VMs and it
>> looks like qxl has the best performance for now.
>> While spice-html5 is more like proof-of-concept, a bit slow and in
>> general not really supported right now.
>>
>> On the other hand, spice-web-client is performant, production solution
>> and supports almost everything the spice can support.
>>
>> The pull request is mostly the drop-in replacement, spice-html5 web
>> client JavaScript gets replaced with spice-web-client JavaScript.
>> I used the latest version of spice-web-client from github:
>> https://github.com/eyeos/spice-web-client - unfortunately guys don't
>> have releases in CDN.
>>
>
> Would this also get rid of mouse acceleration mismatch issues with Windows
> clients?
>
> --
> Joni Orponen
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20180403/5d5630e0/attachment.html>

From cyrille at visgence.com  Sat Apr 21 19:56:41 2018
From: cyrille at visgence.com (cyrille at visgence.com)
Date: Sat, 21 Apr 2018 13:56:41 -0600
Subject: [Kimchi-devel] [PATCH] [Kimchi] Issue #1215: Wrong tab into Storage
	section This commit addresses an issue where table the table
	headers were incorrectly labeling their columns. This
	reorders the items in the tables to properly match the titles.
Message-ID: <1524340601-7240-1-git-send-email-cyrille@visgence.com>

From: Cyrille Gindreau <cyrille at visgence.com>

---
 ui/pages/tabs/storage.html.tmpl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ui/pages/tabs/storage.html.tmpl b/ui/pages/tabs/storage.html.tmpl
index 8a3bd84..8b77e69 100644
--- a/ui/pages/tabs/storage.html.tmpl
+++ b/ui/pages/tabs/storage.html.tmpl
@@ -136,11 +136,11 @@
               </div>
                 <div class="wok-datagrid wok-list">
                     <div class="wok-datagrid-header">
-                        <span class="column-name">$_('Name')</span><!--
-                   --><span class="column-format">$_('Format')</span><!--
-                   --><span class="column-type">$_('Type')</span><!--
-                   --><span class="column-used-by">$_('Used By')</span><!--<!--
+                      <span class="column-name">$_('Name')</span><!--
                    --><span class="column-used">$_('Used')</span><!--
+		   --><span class="column-used-by">$_('Used By')</span><!--
+		   --><span class="column-format">$_('Format')</span><!--
+		   --><span class="column-type">$_('Type')</span><!--
                    --><span class="column-allocated">$_('Allocated')</span><!--
                    --><span class="column-capacity">$_('Capacity')</span><!--
                    --><span class="column-progress hidden">$_('Progress')</span>
-- 
1.8.3.1


From aline.manera at gmail.com  Mon Apr 23 03:31:56 2018
From: aline.manera at gmail.com (aline.manera at gmail.com)
Date: Sun, 22 Apr 2018 23:31:56 -0400
Subject: [Kimchi-devel] [PATCH] [Kimchi 0/3] Integrating with
	spice-web-client
In-Reply-To: <CAFNo1zm86ydX7FSas79_v9R-cxmaPj++ke-uStXoA=ys4FB5aQ@mail.gmail.com>
References: <1515815866-6549-1-git-send-email-pgurenko@gmail.com>
	<CA+jM7rhJ9-2PdnJTPC_+1+1iWE6-T6kSogwXaCie3E5_6XtVFQ@mail.gmail.com>
	<CAFNo1znm_A8kvAvwfxpcEKD=96_yNUYTF-bQm=ZQffYBequQBg@mail.gmail.com>
	<CA+LW3i0cVW3VhZxQPSbv9PoYaODmk_tkyy53xWBQjGeZxCAkQA@mail.gmail.com>
	<CAFNo1zm86ydX7FSas79_v9R-cxmaPj++ke-uStXoA=ys4FB5aQ@mail.gmail.com>
Message-ID: <CA+jM7rj19Ozrdc9jSG0uu=xMhjzLADdSrKKfYt6u_F7WfS869g@mail.gmail.com>

Hi Pavel!

I checked the code and I have some suggestions:

1. The new files added for build do not need to contain the IBM copyright
as you did not that for IBM (or did you do?)

2. For the new functionality itself, I'd propose to add a build parameter,
something like --with-spice-web-client to build the app with
spice-web-client, otherwise, use spice-html5.
That way, we can have a easier way to move forward with Linux distribution
repositories which does not allow third-part JS files into the package.
What do you think about that?

Regards,


On Tue, Apr 3, 2018 at 11:46 AM, Pavel Gurenko <pgurenko at gmail.com> wrote:

> If you mean the ones before installing spice guest tools (two cursors),
> then no, I guess it's not.
> I had no issues with spice guest tools installed.
>
> On Tue, Apr 3, 2018, 2:13 AM Joni Orponen <j.orponen at 4teamwork.ch> wrote:
>
>> On Wed, Mar 28, 2018 at 8:57 PM, Pavel Gurenko <pgurenko at gmail.com>
>> wrote:
>>
>>> The spice-html5 does not support the qxl drivers for Windows VMs and it
>>> looks like qxl has the best performance for now.
>>> While spice-html5 is more like proof-of-concept, a bit slow and in
>>> general not really supported right now.
>>>
>>> On the other hand, spice-web-client is performant, production solution
>>> and supports almost everything the spice can support.
>>>
>>> The pull request is mostly the drop-in replacement, spice-html5 web
>>> client JavaScript gets replaced with spice-web-client JavaScript.
>>> I used the latest version of spice-web-client from github:
>>> https://github.com/eyeos/spice-web-client - unfortunately guys don't
>>> have releases in CDN.
>>>
>>
>> Would this also get rid of mouse acceleration mismatch issues with
>> Windows clients?
>>
>> --
>> Joni Orponen
>> _______________________________________________
>> Kimchi-devel mailing list
>> Kimchi-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
>


-- 
Aline Manera
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20180422/59ec96b0/attachment.html>

From aline.manera at gmail.com  Mon Apr 23 03:37:20 2018
From: aline.manera at gmail.com (aline.manera at gmail.com)
Date: Sun, 22 Apr 2018 23:37:20 -0400
Subject: [Kimchi-devel] [PATCH] [Kimchi] Issue #1215: Wrong tab into
 Storage section This commit addresses an issue where table the table
 headers were incorrectly labeling their columns. This reorders the items in
 the tables to properly match the titles.
In-Reply-To: <1524340601-7240-1-git-send-email-cyrille@visgence.com>
References: <1524340601-7240-1-git-send-email-cyrille@visgence.com>
Message-ID: <CA+jM7rgZsMkX_Q2-SmWY-T7GG+s0gNV6f-U8578bMUq90jqBQg@mail.gmail.com>

Applied. Thanks!

On Sat, Apr 21, 2018 at 3:56 PM, <cyrille at visgence.com> wrote:

> From: Cyrille Gindreau <cyrille at visgence.com>
>
> ---
>  ui/pages/tabs/storage.html.tmpl | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ui/pages/tabs/storage.html.tmpl b/ui/pages/tabs/storage.html.
> tmpl
> index 8a3bd84..8b77e69 100644
> --- a/ui/pages/tabs/storage.html.tmpl
> +++ b/ui/pages/tabs/storage.html.tmpl
> @@ -136,11 +136,11 @@
>                </div>
>                  <div class="wok-datagrid wok-list">
>                      <div class="wok-datagrid-header">
> -                        <span class="column-name">$_('Name')</span><!--
> -                   --><span class="column-format">$_('Format')</span><!--
> -                   --><span class="column-type">$_('Type')</span><!--
> -                   --><span class="column-used-by">$_('Used
> By')</span><!--<!--
> +                      <span class="column-name">$_('Name')</span><!--
>                     --><span class="column-used">$_('Used')</span><!--
> +                  --><span class="column-used-by">$_('Used
> By')</span><!--
> +                  --><span class="column-format">$_('Format')</span><!--
> +                  --><span class="column-type">$_('Type')</span><!--
>                     --><span class="column-allocated">$_('
> Allocated')</span><!--
>                     --><span class="column-capacity">$_('
> Capacity')</span><!--
>                     --><span class="column-progress
> hidden">$_('Progress')</span>
> --
> 1.8.3.1
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>



-- 
Aline Manera
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20180422/8eabe0be/attachment.html>

From pgurenko at gmail.com  Thu Apr 26 03:47:54 2018
From: pgurenko at gmail.com (Pavel Gurenko)
Date: Wed, 25 Apr 2018 20:47:54 -0700
Subject: [Kimchi-devel] [PATCH] [Kimchi 0/3] Integrating with
 spice-web-client
In-Reply-To: <CA+jM7rj19Ozrdc9jSG0uu=xMhjzLADdSrKKfYt6u_F7WfS869g@mail.gmail.com>
References: <1515815866-6549-1-git-send-email-pgurenko@gmail.com>
	<CA+jM7rhJ9-2PdnJTPC_+1+1iWE6-T6kSogwXaCie3E5_6XtVFQ@mail.gmail.com>
	<CAFNo1znm_A8kvAvwfxpcEKD=96_yNUYTF-bQm=ZQffYBequQBg@mail.gmail.com>
	<CA+LW3i0cVW3VhZxQPSbv9PoYaODmk_tkyy53xWBQjGeZxCAkQA@mail.gmail.com>
	<CAFNo1zm86ydX7FSas79_v9R-cxmaPj++ke-uStXoA=ys4FB5aQ@mail.gmail.com>
	<CA+jM7rj19Ozrdc9jSG0uu=xMhjzLADdSrKKfYt6u_F7WfS869g@mail.gmail.com>
Message-ID: <1499758A-B5D5-4EC7-9919-0BE44A5C79A8@gmail.com>

Hi Aline,

1. No, just copy-paste:)
2. That is a bit tricky, how to let client know which spice to use? Added comment in PR.

Created new pull without removing spice-html5 and without copyrights:
https://github.com/kimchi-project/kimchi/pull/1225

Pavel

> On Apr 22, 2018, at 8:31 PM, aline.manera at gmail.com wrote:
> 
> Hi Pavel!
> 
> I checked the code and I have some suggestions:
> 
> 1. The new files added for build do not need to contain the IBM copyright as you did not that for IBM (or did you do?)
> 
> 2. For the new functionality itself, I'd propose to add a build parameter, something like --with-spice-web-client to build the app with spice-web-client, otherwise, use spice-html5.
> That way, we can have a easier way to move forward with Linux distribution repositories which does not allow third-part JS files into the package.
> What do you think about that?
> 
> Regards,
> 
> 
> On Tue, Apr 3, 2018 at 11:46 AM, Pavel Gurenko <pgurenko at gmail.com <mailto:pgurenko at gmail.com>> wrote:
> If you mean the ones before installing spice guest tools (two cursors), then no, I guess it's not.
> I had no issues with spice guest tools installed.
> 
> On Tue, Apr 3, 2018, 2:13 AM Joni Orponen <j.orponen at 4teamwork.ch <mailto:j.orponen at 4teamwork.ch>> wrote:
> On Wed, Mar 28, 2018 at 8:57 PM, Pavel Gurenko <pgurenko at gmail.com <mailto:pgurenko at gmail.com>> wrote:
> The spice-html5 does not support the qxl drivers for Windows VMs and it looks like qxl has the best performance for now.
> While spice-html5 is more like proof-of-concept, a bit slow and in general not really supported right now.
> 
> On the other hand, spice-web-client is performant, production solution and supports almost everything the spice can support.
> 
> The pull request is mostly the drop-in replacement, spice-html5 web client JavaScript gets replaced with spice-web-client JavaScript.
> I used the latest version of spice-web-client from github: https://github.com/eyeos/spice-web-clien <https://github.com/eyeos/spice-web-clien>t - unfortunately guys don't have releases in CDN.
> 
> Would this also get rid of mouse acceleration mismatch issues with Windows clients?
> 
> -- 
> Joni Orponen
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org <mailto:Kimchi-devel at ovirt.org>
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel <http://lists.ovirt.org/mailman/listinfo/kimchi-devel>
> 
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org <mailto:Kimchi-devel at ovirt.org>
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel <http://lists.ovirt.org/mailman/listinfo/kimchi-devel>
> 
> 
> 
> 
> -- 
> Aline Manera

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20180425/572d37e6/attachment.html>