<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Just a minor comment below <br>
<br>
<br>
I have encounter this problems several times. not always happen.<br>
<pre wrap="">======================================================================
FAIL: test_debug_reports (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/run/jenkins/workspace/kimchi_test/tests/test_model.py",
line 639, in test_debug_reports
raise e
File "/run/jenkins/workspace/kimchi_test/tests/test_model.py",
line 632, in test_debug_reports
"It is not necessary an error. "
AssertionError: It is not necessary an error. You may need to
increase the timeout number in _wait_task()
----------------------------------------------------------------------
Ran 114 tests in 130.198s
FAILED (failures=1)
<big>We need this patch. </big>
</pre>
On 01/09/2014 06:40 PM, Shu Ming wrote:<br>
</div>
<blockquote
cite="mid:1389264033-32485-3-git-send-email-shuming@linux.vnet.ibm.com"
type="cite">
<pre wrap="">It is helpful when the timeout happens and the tester can tune it</pre>
</blockquote>
you can give more information tell how to tune
timeout
<br>
<br>
$ TEST_REPORT_TIMEOUT=120 ./run_tests.sh test_mode<br>
<br>
<blockquote
cite="mid:1389264033-32485-3-git-send-email-shuming@linux.vnet.ibm.com"
type="cite">
<pre wrap="">
Signed-off-by: Shu Ming <a class="moz-txt-link-rfc2396E" href="mailto:shuming@linux.vnet.ibm.com"><shuming@linux.vnet.ibm.com></a>
---
tests/test_model.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/test_model.py b/tests/test_model.py
index dad4670..41032f7 100644
--- a/tests/test_model.py
+++ b/tests/test_model.py
@@ -614,6 +614,11 @@ class ModelTests(unittest.TestCase):
if not inst.get_capabilities()['system_report_tool']:
raise unittest.SkipTest("Without debug report tool")
+ try:
+ timeout = int(os.environ['TEST_REPORT_TIMEOUT'])
+ except (ValueError, KeyError):
+ timeout = 120
+
namePrefix = 'unitTestReport'
# sosreport always deletes unsual letters like '-' and '_' in the
# generated report file name.
@@ -630,7 +635,7 @@ class ModelTests(unittest.TestCase):
task = inst.debugreports_create({'name': reportName})
rollback.prependDefer(inst.debugreport_delete, reportName)
taskid = task['id']
- self._wait_task(inst, taskid, 60)
+ self._wait_task(inst, taskid, timeout)
self.assertEquals('finished',
inst.task_lookup(taskid)['status'],
"It is not necessary an error. "
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Thanks and best regards!
Sheldon Feng(冯少合)<a class="moz-txt-link-rfc2396E" href="mailto:shaohef@linux.vnet.ibm.com"><shaohef@linux.vnet.ibm.com></a>
IBM Linux Technology Center</pre>
</body>
</html>