<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Mark, thanks for the feedback!<br>
<br>
I haven't read the PEP8 correctly, I thought the length limit was 80
characters, but I see it's 79 indeed.<br>
<br>
I decided to validate only this PEP8 feature for now (maximum line
length) for all files instead of completely cleaning file by file.
At least now there'll be one less rule left :-) <br>
<br>
I'll send a new patch fixing the new line length value.<br>
<br>
<div class="moz-cite-prefix">Am 21-01-2014 23:41, schrieb Mark Wu:<br>
</div>
<blockquote cite="mid:52DF21C1.3010901@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Crístian,<br>
<br>
I like the idea of cleanup, but for python projects, we should
comply with PEP8[1], which limit all lines to a maximum of 79
characters.
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
So after we can all files pep clean, it will resolve the line
length problem too. <br>
<br>
If you have interest in the pep8 clean, you could use the
command line tool pep8 and or vim plugin[2] to check if a python
file is pep8 clean. After the cleanup, we need put it to the
list of PEP8_WHITELIST in Makefile.am. It can guarantee the
files are checked when 'make check-local' is executed.<br
class="Apple-interchange-newline">
<br>
[1]
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<a moz-do-not-send="true"
href="http://www.python.org/dev/peps/pep-0008/#maximum-line-length">http://www.python.org/dev/peps/pep-0008/#maximum-line-length</a>
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<br>
[2]
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<a moz-do-not-send="true"
href="https://github.com/kimchi-project/kimchi/wiki/PEP8-Checking-Using-Syntastic">https://github.com/kimchi-project/kimchi/wiki/PEP8-Checking-Using-Syntastic</a><br>
</div>
</blockquote>
</body>
</html>