<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 01/23/2014 12:01 AM, Mark Wu wrote:<br>
</div>
<blockquote cite="mid:52E07808.1080202@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 01/22/2014 08:54 PM, Crístian
Viana wrote:<br>
</div>
<blockquote cite="mid:52DFBF83.9000606@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Mark, thanks for the feedback!<br>
<br>
I haven't read the PEP8 correctly, I thought the length limit
was 80 characters, but I see it's 79 indeed.<br>
<br>
I decided to validate only this PEP8 feature for now (maximum
line length) for all files instead of completely cleaning file
by file. At least now there'll be one less rule left :-) <br>
<br>
I'll send a new patch fixing the new line length value.<br>
</blockquote>
Personally, I don't like the fix special for the line length. I
prefer to include it in a pep8 clean for a file.<br>
The reason is that: even if fix the line length, we don't have a
tool to check new changed code does't<br>
have this problem. But for pep8, there's no this kind of
problem. After we clean up one file, we can<br>
add it to the WHITELIST, and the developer can check if it cause
new style problem by running 'make check-local'<br>
<br>
</blockquote>
<br>
I agree with Mark.<br>
Even if we correct the line length now there is no way to guarantee
new code will respect that in future.<br>
<br>
<blockquote cite="mid:52E07808.1080202@linux.vnet.ibm.com"
type="cite"> <br>
<br>
<br>
<blockquote cite="mid:52DFBF83.9000606@linux.vnet.ibm.com"
type="cite"> <br>
<div class="moz-cite-prefix">Am 21-01-2014 23:41, schrieb Mark
Wu:<br>
</div>
<blockquote cite="mid:52DF21C1.3010901@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Crístian,<br>
<br>
I like the idea of cleanup, but for python projects, we
should comply with PEP8[1], which limit all lines to a
maximum of 79 characters.
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
So after we can all files pep clean, it will resolve the
line length problem too. <br>
<br>
If you have interest in the pep8 clean, you could use the
command line tool pep8 and or vim plugin[2] to check if a
python file is pep8 clean. After the cleanup, we need put
it to the list of PEP8_WHITELIST in Makefile.am. It can
guarantee the files are checked when 'make check-local' is
executed.<br class="Apple-interchange-newline">
<br>
[1]
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a moz-do-not-send="true"
href="http://www.python.org/dev/peps/pep-0008/#maximum-line-length">http://www.python.org/dev/peps/pep-0008/#maximum-line-length</a>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<br>
[2]
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a moz-do-not-send="true"
href="https://github.com/kimchi-project/kimchi/wiki/PEP8-Checking-Using-Syntastic">https://github.com/kimchi-project/kimchi/wiki/PEP8-Checking-Using-Syntastic</a><br>
</div>
</blockquote>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>