<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
<br>
On 01/30/2014 03:23 PM, Aline Manera wrote:<br>
</div>
<blockquote cite="mid:52EA8AAC.8040301@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 01/21/2014 02:34 PM, Rodrigo
Trujillo wrote:<br>
</div>
<blockquote cite="mid:52DEA18A.2070901@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 01/20/2014 02:24 PM, Aline
Manera wrote:<br>
</div>
<blockquote cite="mid:52DD4DBF.9010201@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 01/17/2014 04:41 PM, Rodrigo
Trujillo wrote:<br>
</div>
<blockquote
cite="mid:1389984065-5871-2-git-send-email-rodrigo.trujillo@linux.vnet.ibm.com"
type="cite">
<pre wrap="">The xml file had wrong entries, then kimchi UI did not recognize the
tabs. This patch fixes this problem and also disables the sample plugin
by default.
Signed-off-by: Rodrigo Trujillo <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:rodrigo.trujillo@linux.vnet.ibm.com"><rodrigo.trujillo@linux.vnet.ibm.com></a>
---
plugins/sample/sample.conf | 7 ++++++-
plugins/sample/ui/config/tab-ext.xml | 8 ++++----
plugins/sample/ui/tab.html | 1 +
3 files changed, 11 insertions(+), 5 deletions(-)
create mode 100644 plugins/sample/ui/tab.html
diff --git a/plugins/sample/sample.conf b/plugins/sample/sample.conf
index c4e80f7..1a8d6b4 100644
--- a/plugins/sample/sample.conf
+++ b/plugins/sample/sample.conf
@@ -1,7 +1,12 @@
[kimchi]
-enable = True
+enable = False
plugin_class = "Drawings"
uri = "/plugins/sample"
[/]
tools.trailing_slash.on = False
+
+
+[/ui/tab.html]
+tools.staticfile.on: True
+tools.staticfile.filename: kimchi.config.get_plugins_dir() + '/sample/ui/tab.html'</pre>
</blockquote>
<br>
I was expecting have a plugins/sample/sample.conf.in with:<br>
<br>
tools.staticfile.on: True<br>
tools.staticfile.filename: '<b>@pluginddir@</b>/sample/ui/tab.html'
<br>
<br>
Then we add it to Makefile.am to do the replacement during
build process.<br>
<br>
So when we get kimchi installed the plugins/sample/sample.conf
file will have the correct full path<br>
<br>
Does that make sense for you?<br>
</blockquote>
<br>
Hi Aline, I considered and thought about your approach, but I
did not implemented it because it will only work for this
plugin, which is built together with whole Kimchi code.<br>
I my opinion, the sample plugin should be a guide for how to
develop new plugins (for now, at least, as we don't a
documentation and the plugin framework is still being refined).<br>
What do you think ?<br>
<br>
</blockquote>
<br>
First of all, sorry for the late message.<br>
<br>
As it will be a guide to new plugins development we need to
address it in the best way to <span class="gt-baf-word-clickable">disseminate</span><span
class="gt-baf-back"></span> it.<br>
For that, I sill think the best way is using autoconf/automake to
generate the correct entry in the config file.<br>
</blockquote>
<br>
How could an external plugin rpm being compiled/built in a
different machine know the value of what is in<br>
kimchis autoconf/automake ??<br>
<br>
But, nevermind, you can ignore this patch ... Mark have worked in
something else related to paths.<br>
<br>
<blockquote cite="mid:52EA8AAC.8040301@linux.vnet.ibm.com"
type="cite"> <br>
<br>
<blockquote cite="mid:52DEA18A.2070901@linux.vnet.ibm.com"
type="cite">
<blockquote cite="mid:52DD4DBF.9010201@linux.vnet.ibm.com"
type="cite"> <br>
<blockquote
cite="mid:1389984065-5871-2-git-send-email-rodrigo.trujillo@linux.vnet.ibm.com"
type="cite">
<pre wrap="">diff --git a/plugins/sample/ui/config/tab-ext.xml b/plugins/sample/ui/config/tab-ext.xml
index 948fa07..d1f8456 100644
--- a/plugins/sample/ui/config/tab-ext.xml
+++ b/plugins/sample/ui/config/tab-ext.xml
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
-<!--<tabs-ext>
+<tabs-ext>
<tab>
- <title>Test</title>
- <filePath>plugins/sample/ui/tab.html</filePath>
+ <title>Sample</title>
+ <path>plugins/sample/ui/tab.html</path>
</tab>
-</tabs-ext>-->
\ No newline at end of file
+</tabs-ext>
diff --git a/plugins/sample/ui/tab.html b/plugins/sample/ui/tab.html
new file mode 100644
index 0000000..1562713
--- /dev/null
+++ b/plugins/sample/ui/tab.html
@@ -0,0 +1 @@
+This is a test TAB for SAMPLE plugin
</pre>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>