<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 03/05/2014 02:25 AM, Aline Manera
wrote:<br>
</div>
<blockquote cite="mid:53161A9B.4020003@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix"><br>
The UI looks good!<br>
I'd just suggest to keep the edit window silver instead of white<br>
</div>
</blockquote>
Thanks! It's changed by jQuery UI and I was unaware of it. Will
include it in next patch.<br>
<blockquote cite="mid:53161A9B.4020003@linux.vnet.ibm.com"
type="cite">
<div class="moz-cite-prefix"> <br>
And I am not able to remove a cdrom<br>
</div>
</blockquote>
Any details? It works in my machine. Attaching one, replacing one,
or detaching one works well.<br>
<blockquote cite="mid:53161A9B.4020003@linux.vnet.ibm.com"
type="cite">
<div class="moz-cite-prefix"> From the log I got:<br>
<br>
127.0.0.1 - - [04/Mar/2014:15:22:19] "GET
/?cdrom=%2Fhome%2Falinefm%2Fisos%2FFedora-Live-Desktop-x86_64-19-1.iso&cdrom=%2Fhome%2Falinefm%2Fisos%2FopenSUSE-13.1-GNOME-Live-x86_64.iso&cdrom=%2Fhome%2Falinefm%2Fisos%2FopenSUSE-13.1-GNOME-Live-x86_64.iso
HTTP/1.1" 404 1606 <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E" href="http://localhost:8000/">"http://localhost:8000/"</a>
"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:27.0) Gecko/20100101
Firefox/27.0"<br>
</div>
</blockquote>
Detaching a CDROM will send a request in format:<br>
<br>
DELETE /vms/vm-name/storages/hdx<br>
<br>
Not saw similar requests like this.<br>
<blockquote cite="mid:53161A9B.4020003@linux.vnet.ibm.com"
type="cite">
<div class="moz-cite-prefix"> <br>
And on UI<br>
<div class="error-msg error-icon">
<div class=" error-text">
<h4>ERROR CODE</h4>
</div>
<div class="error-text"> <span>404 Not Found</span> </div>
<div class="error-text">
<h4>REASON</h4>
</div>
<div class="error-text"> <span>Unexpected query string
parameters: cdrom</span> </div>
<div class="error-text">
<h4>STACK</h4>
</div>
<div class="error-text">
<pre>Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/cherrypy/_cprequest.py", line 656, in respond
response.body = self.handler()
File "/usr/lib/python2.7/dist-packages/cherrypy/lib/encoding.py", line 188, in __call__
self.body = self.oldhandler(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/cherrypy/_cpdispatch.py", line 40, in __call__
raise sys.exc_info()[1]
HTTPError: (404, 'Unexpected query string parameters: cdrom')
</pre>
</div>
</div>
<br>
On 03/04/2014 06:01 AM, Hongliang Wang wrote:<br>
</div>
<blockquote
cite="mid:1393923676-5629-1-git-send-email-hlwang@linux.vnet.ibm.com"
type="cite">
<pre wrap="">Allow user to manipulate CDROM(s) in a VM:
1) Attach one or more CDROM(s);
2) Replace a CDROM with another ISO file path;
3) Detach a CDROM from a VM.
Tested on Chrome.
Please apply the following patch first:
* [UI] Window - Correct Footer Height
v1 -> v2:
2a) Separate one patch into 4 small ones to make it easier to review
(Thanks to Ramon Medeiros's comment)
2b) Updated API calling to list CDROM
(Thanks to Aline's comment)
2c) Separated VM updating window into 2 parts: general and storage
(Thanks to Aline's comment)
2d) Enhanced UI to allow user trigger replace CDROM window by clicking
ISO file path text box
2e) Changed uneditable fields from readonly to disabled
2f) Removed authors infomation
(Thanks to Aline's comment)
Hongliang Wang (4):
[UI] Add CDROM-related APIs
[UI] Add i18n Variables for CDROM-related Function
[UI] Add/Edit CDROM Support
[UI] Attach/Replace/Detach a CDROM to/in/from a VM
ui/css/theme-default/guest-cdrom-add.css | 62 +++++++++++
ui/css/theme-default/guest-cdrom-edit.css | 62 +++++++++++
ui/css/theme-default/guest-edit.css | 108 +++++++++++++++---
ui/images/theme-default/guest-icon-sprite.png | Bin 0 -> 6748 bytes
ui/js/src/kimchi.api.js | 74 +++++++++++++
ui/js/src/kimchi.guest_cdrom_add_main.js | 79 +++++++++++++
ui/js/src/kimchi.guest_cdrom_edit_main.js | 87 +++++++++++++++
ui/js/src/kimchi.guest_edit_main.js | 75 ++++++++++++-
ui/pages/guest-cdrom-add.html.tmpl | 73 ++++++++++++
ui/pages/guest-cdrom-edit.html.tmpl | 73 ++++++++++++
ui/pages/guest-edit.html.tmpl | 153 +++++++++++++++++---------
ui/pages/i18n.html.tmpl | 5 +
12 files changed, 778 insertions(+), 73 deletions(-)
create mode 100644 ui/css/theme-default/guest-cdrom-add.css
create mode 100644 ui/css/theme-default/guest-cdrom-edit.css
create mode 100644 ui/images/theme-default/guest-icon-sprite.png
create mode 100644 ui/js/src/kimchi.guest_cdrom_add_main.js
create mode 100644 ui/js/src/kimchi.guest_cdrom_edit_main.js
create mode 100644 ui/pages/guest-cdrom-add.html.tmpl
create mode 100644 ui/pages/guest-cdrom-edit.html.tmpl
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>