<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 03/08/2014 02:27 AM, Aline Manera
wrote:<br>
</div>
<blockquote cite="mid:531A0FAF.5050802@linux.vnet.ibm.com"
type="cite"><br>
<p>So when starting kimchi we just need to make sure the default
network/storage pool are active.<br>
And activate them if needed.<br>
For nested virtualization, the default network will fail to
activate as the address is already in use.<br>
In this case, we can get the properly error and automatically
edit the default network for the user to get an unused address.</p>
<p>So the steps to close issue #302 are:<br>
1) Check if libvirt creates the default network/storage pool by
default<br>
1.1) If so, remove this code from kimchi code<br>
</p>
</blockquote>
Actually, there are 2 issues about "default" network/storage pool
on git hub. <br>
<a class="moz-txt-link-freetext" href="https://github.com/kimchi-project/kimchi/issues/56">https://github.com/kimchi-project/kimchi/issues/56</a><br>
<a class="moz-txt-link-freetext" href="https://github.com/kimchi-project/kimchi/issues/24">https://github.com/kimchi-project/kimchi/issues/24</a><br>
<br>
Here is some history about these bugs:<br>
<b>From adam:</b><br>
Recently I have found that some distributions (Fedora 17+) separate
the
network config into another package. On Fedora it's
libvirt-daemon-config-network. Can you just check if adding that as
a
package dependency will resolve the problem? If so, let's find out
if
the same solution will resolve the problem of the missing default
storage pool.<br>
<b><br>
From BingBu:<br>
</b>'libvirt-daemon-config-network' package is in the libvirt
deplist, so if you installed the libvirt, the
libvirt-daemon-config-network is installed as as well. I don't think
we should add it to the dependency.<b><br>
<br>
</b><b>From Aline:</b><br>
I've already gotten an error about the network default was not
active.
<br>
It should be good to know which networks are available and active.
<br>
<br>
I also send a patch to fix this patch.<br>
[project-kimchi] [PATCH] bug fix: Add a default network if no
network exists<br>
<br>
But I give up for:<br>
1. as Bingbu comments:<br>
we should avoid hard code.<br>
2. as Bingbu investigation:<br>
'libvirt-daemon-config-network' package is in the libvirt deplist<br>
3. we can make use the network REST API, networks_create method. <br>
<br>
But later another similar patch was sent and merged, it introduce
hard code.<br>
[project-kimchi] [PATCH 4/4] Create default network if it does not
exist<br>
commit <a
href="https://github.com/kimchi-project/kimchi/commit/71a3a883906f54ae8a5bdc9480258b9223aef2c0"
class="commit-link"><tt>71a3a88</tt></a>.<br>
<br>
I really do not know why this patch was merged, though some of us do
not think this patch is well. <br>
So here I just fixed the #302 introduce by <a
href="https://github.com/kimchi-project/kimchi/commit/71a3a883906f54ae8a5bdc9480258b9223aef2c0"
class="commit-link"><tt>71a3a88</tt></a>, remove the hard code to
avoid some bugs. <br>
<br>
<blockquote cite="mid:531A0FAF.5050802@linux.vnet.ibm.com"
type="cite">
<p> 2) On Kimchi start up, make sure default network/storage pool
are active.<br>
2.1) If network activate fails <em>because</em> of the
address is already in use, kimchi automatically update the
network address and start it.</p>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Thanks and best regards!
Sheldon Feng(冯少合)<a class="moz-txt-link-rfc2396E" href="mailto:shaohef@linux.vnet.ibm.com"><shaohef@linux.vnet.ibm.com></a>
IBM Linux Technology Center</pre>
</body>
</html>