<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 04/22/2014 01:59 PM, Aline Manera
wrote:<br>
</div>
<blockquote cite="mid:53569FDC.5000309@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 04/22/2014 12:59 AM, <a
moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:shaohef@linux.vnet.ibm.com">shaohef@linux.vnet.ibm.com</a>
wrote:<br>
</div>
<blockquote
cite="mid:1398139189-26732-1-git-send-email-shaohef@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: ShaoHe Feng <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:shaohef@linux.vnet.ibm.com"><shaohef@linux.vnet.ibm.com></a>
V2 -> V3:
move the virDomain.metadata and virDomain.setMetadata to model/utils.py
add testcase
V1 -> V2:
libvirt also support virDomain.metadata and virDomain.setMetadata two api.
use virDomain.metadata to get the user and group.
use virDomain.setMetadata to set the user and group.
ShaoHe Feng (3):
Add two function to set and get domain xml metadata
bug fix: get user and group when vm is living.
update test case to set/get user and group when VM is running
src/kimchi/i18n.py | 1 +
src/kimchi/model/utils.py | 41 ++++++++++++++++++++++++++++++
src/kimchi/model/vms.py | 65 +++++++++++++++++++++++------------------------
tests/test_model.py | 13 ++++++++++
4 files changed, 87 insertions(+), 33 deletions(-)
</pre>
</blockquote>
<font face="DejaVu Sans Mono">As I commented in previous version,
</font><font face="DejaVu Sans Mono">virDomain.metadata and
virDomain.setMetadata does not work <br>
well in all libvirt versions<br>
</font><br>
----------------------------------------<br>
<br>
During the first development, I noticed the virDomain.metadata and
virDomain.setMetadata does not work <br>
well in all libvirt versions. <br>
<br>
While using those functions, some libvirt versions will report: <br>
<br>
libvir: QEMU Driver error : argument unsupported: QEMU driver does
not support<metadata> element <br>
<br>
But if you manually get and set metadata element, libvirt works
fine. <br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
I agree with the other changes you proposed in this patch but you
need to keep manually manage the metadata element <br>
until we get virDomain.metadata and virDomain.setMetadata working in
all livirt versions used in the supported distros.<br>
<br>
<blockquote cite="mid:53569FDC.5000309@linux.vnet.ibm.com"
type="cite">
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>