<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">ACK<br>
On 05/07/2014 12:49 AM, Aline Manera wrote:<br>
</div>
<blockquote cite="mid:53691280.6030301@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 05/04/2014 07:13 AM, <a
moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:lvroyce@linux.vnet.ibm.com">lvroyce@linux.vnet.ibm.com</a>
wrote:<br>
</div>
<blockquote
cite="mid:1399198393-15440-1-git-send-email-lvroyce@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Royce Lv <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:lvroyce@linux.vnet.ibm.com"><lvroyce@linux.vnet.ibm.com></a>
Yu Xin Huo (1):
StoragePool Edit: Add Disk to Logical Pool
Royce Lv (2):
StoragePool Edit: Add Disk to Logical Pool
StoragePool Edit: Update json schema
src/kimchi/API.json | 3 ++-
ui/js/src/kimchi.api.js | 12 ++++++++++
ui/js/src/kimchi.storage_main.js | 41 ++++++++++++++++++++++++++++++++
ui/js/src/kimchi.storagepool_add_main.js | 2 +-
ui/pages/i18n.html.tmpl | 1 +
ui/pages/tabs/storage.html.tmpl | 10 ++++++++
6 files changed, 67 insertions(+), 2 deletions(-)
</pre>
</blockquote>
<br>
<font face="DejaVu Sans Mono">Some comments:<br>
<br>
1) When there is any device available, an empty window is
displayed.<br>
<br>
</font><br>
<img src="cid:part3.07060101.04000407@linux.vnet.ibm.com" alt=""><br>
<br>
2) And even when there are device available there is a lack until
window be populated.<br>
<br>
My suggestion is add a loading icon or loading mouse point, until
get the list of devices<br>
And if no device is available display a message.<br>
<br>
The code looks good for me.<br>
Maybe a UI expert can do a better review.<br>
<br>
</blockquote>
<br>
</body>
</html>