<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Bump<br>
    <br>
    What's the status of this contribution?<br>
    <br>
    <br>
    Thanks!<br>
    <br>
    <br>
    <div class="moz-cite-prefix">On 06/05/2014 11:57 AM, Aline Manera
      wrote:<br>
    </div>
    <blockquote cite="mid:53908571.6030309@linux.vnet.ibm.com"
      type="cite">
      <meta content="text/html; charset=ISO-8859-1"
        http-equiv="Content-Type">
      <div class="moz-cite-prefix">On 05/30/2014 05:49 AM, Yu Xin Huo
        wrote:<br>
      </div>
      <blockquote cite="mid:53884611.7030408@linux.vnet.ibm.com"
        type="cite">
        <meta content="text/html; charset=ISO-8859-1"
          http-equiv="Content-Type">
        <div class="moz-cite-prefix">1. the location of this message
          indicate that it is only a progress indicator of the 4th step?
          I tend to think it should be a progress indicator of the whole
          pool generating process<br>
          2. do not expect this kind of slow task to block whole UI.<br>
          3. Please reference to "[Kimchi-devel] [PATCH] Issue #296
          [enhance]kimchi UI should not waiting while generating
          reports" to handle it.<br>
          <br>
          <img src="cid:part1.03000201.00060306@linux.vnet.ibm.com"
            alt=""><br>
          <br>
        </div>
      </blockquote>
      <br>
      Is it important to explicit show a message?<br>
      I thought in just change the mouse cursor to a loading one when
      selecting "Create" button<br>
      <br>
      <blockquote cite="mid:53884611.7030408@linux.vnet.ibm.com"
        type="cite">
        <div class="moz-cite-prefix"> On 5/26/2014 11:21 AM, <a
            moz-do-not-send="true" class="moz-txt-link-abbreviated"
            href="mailto:lvroyce@linux.vnet.ibm.com">lvroyce@linux.vnet.ibm.com</a>
          wrote:<br>
        </div>
        <blockquote
          cite="mid:1401074519-6677-1-git-send-email-lvroyce@linux.vnet.ibm.com"
          type="cite">
          <pre wrap="">From: Royce Lv <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:lvroyce@linux.vnet.ibm.com">&lt;lvroyce@linux.vnet.ibm.com&gt;</a>

v1&gt;v2, Improve feedback msg according to Hongliang's comments.

Add loading icon to indicate nfs mount in progress,
when error or normal response returns,
close create window.

Signed-off-by: Royce Lv <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:lvroyce@linux.vnet.ibm.com">&lt;lvroyce@linux.vnet.ibm.com&gt;</a>
---
 ui/js/src/kimchi.storagepool_add_main.js | 2 ++
 ui/pages/storagepool-add.html.tmpl       | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js
index 86dbe7f..6b77bd8 100644
--- a/ui/js/src/kimchi.storagepool_add_main.js
+++ b/ui/js/src/kimchi.storagepool_add_main.js
@@ -198,6 +198,7 @@ kimchi.validateNfsForm = function () {
         kimchi.message.error.code('KCHPOOL6005E');
         return false;
     }
+    $('#nfs-mount-loading').removeClass('hidden');
     return true;
 };

@@ -295,6 +296,7 @@ kimchi.addPool = function(event) {
                 kimchi.window.close();
             }, function(err) {
                 kimchi.message.error(err.responseJSON.reason);
+                kimchi.window.close();
             });
         }
     }
diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl
index 977db66..b033b36 100644
--- a/ui/pages/storagepool-add.html.tmpl
+++ b/ui/pages/storagepool-add.html.tmpl
@@ -91,6 +91,12 @@
                                     &lt;/ul&gt;
                                 &lt;/div&gt;
                             &lt;/div&gt;
+                            &lt;div class="hidden" id="nfs-mount-loading"&gt;
+                                &lt;p class="text-help"&gt;
+                                    $_("Trying to mount NFS export path. It may take several seconds.")
+                                    &lt;img src = "../images/theme-default/loading.gif" /&gt;</pre>
        </blockquote>
        icon should be placed before text.<br>
        <blockquote
          cite="mid:1401074519-6677-1-git-send-email-lvroyce@linux.vnet.ibm.com"
          type="cite">
          <pre wrap="">+                                &lt;/p&gt;
+                            &lt;/div&gt;
                         &lt;/div&gt;
                     &lt;/section&gt;
                 &lt;/div&gt;
</pre>
        </blockquote>
        <br>
        <br>
        <fieldset class="mimeAttachmentHeader"></fieldset>
        <br>
        <pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
      </blockquote>
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>