<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 06/09/2014 11:59 PM, Aline Manera
wrote:<br>
</div>
<blockquote cite="mid:5395D9CE.2020600@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 06/09/2014 04:25 AM, Hongliang
Wang wrote:<br>
</div>
<blockquote cite="mid:5395615B.6010409@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 06/07/2014 01:16 AM, Aline
Manera wrote:<br>
</div>
<blockquote cite="mid:5391F775.8050909@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 06/06/2014 03:49 AM, Hongliang
Wang wrote:<br>
</div>
<blockquote
cite="mid:1402037382-6455-1-git-send-email-hlwang@linux.vnet.ibm.com"
type="cite">
<pre wrap="">Make guest cdrom edit UI consistent with guest interface edit UI. The key point
is to edit cdrom properties in place. Because there is only one property can be
updated for a cdrom, it works fine this way. Though another inconsistence comes
up that in the same storage tab, there is also lines for disks, which have more
editable properties and it's not that easy to make all of these properties stay
in one line. So for disks, possibly we still need provide another window to let
users update properties.
So here are 2 choices:
C1) Apply this PATCH v2 to keep cdrom consistent with interface
C2) Apply PATCH v1 to keep cdrom consistent with disk
Both are OK for me.
v1 -> v2:
2a) Made updating cdrom properties in place
(Aline's comment)
Hongliang Wang (2):
Adjust Guest Edit Storage Tab Styles
Remove Unused Files
ui/css/theme-default/guest-cdrom-edit.css | 57 ------------
ui/css/theme-default/guest-edit.css | 99 +++++++-------------
ui/images/theme-default/guest-icon-sprite.png | Bin 6748 -> 0 bytes
ui/js/src/kimchi.guest_cdrom_edit_main.js | 85 ------------------
ui/js/src/kimchi.guest_edit_main.js | 125 +++++++++++++++++++++-----
ui/pages/guest-cdrom-edit.html.tmpl | 70 ---------------
ui/pages/guest-edit.html.tmpl | 57 +++++++-----
7 files changed, 166 insertions(+), 327 deletions(-)
delete mode 100644 ui/css/theme-default/guest-cdrom-edit.css
delete mode 100644 ui/images/theme-default/guest-icon-sprite.png
delete mode 100644 ui/js/src/kimchi.guest_cdrom_edit_main.js
delete mode 100644 ui/pages/guest-cdrom-edit.html.tmpl
</pre>
</blockquote>
<br>
<font face="DejaVu Sans Mono">We also need to keep consistence
in the "+"</font> button.<br>
In the network tab, it adds a new line to the list and user
change the values accordingly.<br>
And in the storage tab, a new dialog is displayed to collect
user input.<br>
<br>
Could you send a separate patch for that?<br>
</blockquote>
Hi Aline, as I was adding this feature, I found it's different
from interface that for storage, there is not only CDROMs, but
also disks. There are more settings for disks so I suggest
retain the pop-up window for attaching devices.<br>
<br>
</blockquote>
<br>
<font face="DejaVu Sans Mono">Good point!<br>
<br>
And if we do the following:<br>
<br>
1) user select + and we add a new line and set the default
values for cdrom<br>
<br>
Type Path<br>
cdrom <an empty input box><br>
<br>
2) if user changes type to "disk", we replace the input box for
2 combo boxes, one for storage pool and other for storage volume<br>
<br>
Type Path<br>
disk |storage pool| |storage volume|<br>
<br>
When user selects "Save" we will know the path based on storage
pool and volume, and turns to the first UI<br>
<br>
Type Path<br>
cdrom /var/lib/libvirt/myiso.iso<br>
disk /var/lib/libvirt/mypool/mypool-vol.img<br>
<br>
What do you think?<br>
</font></blockquote>
<font face="DejaVu Sans Mono">That's good! I made a mock-up UI and
it looks fine (though I forgot to capture a screen shot :-( ).
There are 5 fields as follow:<br>
<br>
Device Name | Device Type | Device Bus |
Path +<br>
vda Disk IDE
/kvmfiles/images/381d4f75-8ee2-43d3-b509-20e80e715544-0.img<br>
hda CDROM IDE
/kvmfiles/images/Fedora-18-x86_64-Live-Desktop.iso<br>
<br>
<br>
The only problem left here is the style issue. We were applying
relatively "big" fonts and icons, though we are switching to
relatively small icons and controls. A re-design needs to make
Kimchi UI consistent.<br>
<br>
Big style for drop-down list used in most parts of Kimchi<br>
<img alt="" src="cid:part1.03000609.03090006@linux.vnet.ibm.com"
height="83" width="641"><br>
<br>
Small style for drop-down list used here<br>
<img alt="" src="cid:part2.02040101.04000606@linux.vnet.ibm.com"
height="95" width="585"><br>
<br>
<br>
<br>
<br>
<br>
<br>
</font><br>
</body>
</html>