<html>
<head>
<meta content="text/html; charset=gbk" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/12/2014 05:55 AM, ssdxiao wrote:<br>
</div>
<blockquote
cite="mid:e538ade.1ee65.1468f499e90.Coremail.ssdxiao@163.com"
type="cite">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial">
<div><br>
</div>
<div>Hi,</div>
<div><span style="line-height: 1.7;">Agree with </span><span
style="line-height: 1.7; font-family: arial; white-space:
pre-wrap;">Royce. </span></div>
<div>This is the use case£º</div>
<div>Machine A£¨where the kimchid is running).</div>
<div>Machine B (the browser which is connetting to the machine
A's kimchi).</div>
<div><br>
</div>
<div>Step1: upload the iso(locate on the B) from B to A.</div>
<div>Step2: search the iso in A and create a template.</div>
<div>Step3: use the template boot a vm.</div>
<br>
</div>
</blockquote>
<br>
<small>Got it. Thanks!<br>
I got messed as I tested it locally. =)<br>
<br>
About the patch, I agree if Royce - we need to improve the UI.<br>
<br>
You should split your patch set in small patches.<br>
I'd say 3 patches:<br>
<br>
1) For the imported code<br>
That way we easily identify which patches we need to really
review the code<br>
2) For backend code<br>
3) For UI code<br>
<br>
You added a new optional to create a template but it only uploads
the ISO to Kimchi server.<br>
I'd expect it to upload and create the template itself<br>
<br>
The API should be:<br>
<br>
1) POST /storagepools/<ootb-pool>/upload {'file':
<filename>}<br>
This URI will be responsible to upload the file to Kimchi
server and it will be only available for the storagepool resource<br>
<br>
2) POST /templates/ {'cdrom': <path to file uploaded
earlier>}<br>
<br>
<br>
<br>
<br>
<br>
</small>
</body>
</html>