<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
The patch seems good for me.<br>
Just some comments about how the UI looks for a user.<br>
<br>
<img src="cid:part1.00060801.06050504@linux.vnet.ibm.com" alt=""><br>
<br>
<div class="moz-cite-prefix"><br>
<img src="cid:part2.09000300.01040409@linux.vnet.ibm.com" alt=""><br>
<br>
<br>
In the storage tab, we should expand the last column just enough
to display the \/ icon<br>
<br>
| ISO 63% | * | /var/lib/kimchi/isos
| dir | 49.1G |
31.2G | \/ |<br>
<br>
<br>
In the network tab, there is a tiny white line in the last column
where it would be the actions menu<br>
<br>
<br>
On 07/22/2014 06:51 AM, <a class="moz-txt-link-abbreviated" href="mailto:wenwang@linux.vnet.ibm.com">wenwang@linux.vnet.ibm.com</a> wrote:<br>
</div>
<blockquote
cite="mid:1406022687-20922-1-git-send-email-wenwang@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Wen Wang <a class="moz-txt-link-rfc2396E" href="mailto:wenwang@linux.vnet.ibm.com"><wenwang@linux.vnet.ibm.com></a>
V2 -> V3:
stored the mode into global _tabMode that can be used for each tab.(Aline)
Making the buttons that is not avaiable for non-root users invisible
by default and enable when user is admin.(Yu Xin)
Fixed css inconsistent under "Storage" tab.
Removed the onClick function if the buttons are not avaiable.
V1 -> V2:
Store "roles" parameter in cookie instead of each tab's mode.(Aline)
read only "roles" from cookie instead of roles of each tab(Aline)
Minor changes in method of removing "Action" title under network tab
(Hongliang Wang)
This patch defines user privilege according to different user roles In this
release, only two roles are supported: "admin" and "user", conbined with four
modes: "admin", "byInstance", "read-only" and "none", each of which has own
privileges to different tabs as well as instances. modes are stored in cookie
and functions of different roles are protected in the back-end.
Wen Wang (4):
Add roles into cookie
Authorization: remove host/template tabs for non-root users
Authorization: remove [+] icon from non-root users view
Authorization: Remove actions based on roles
ui/css/theme-default/storage.css | 22 ++++---
ui/js/src/kimchi.guest_main.js | 10 ++-
ui/js/src/kimchi.login.js | 16 +++--
ui/js/src/kimchi.main.js | 26 +++++--
ui/js/src/kimchi.network.js | 10 +++-
ui/js/src/kimchi.storage_main.js | 137 ++++++++++++++++++++-----------------
ui/js/src/kimchi.template_main.js | 21 ++++--
ui/pages/tabs/guests.html.tmpl | 4 +-
ui/pages/tabs/network.html.tmpl | 6 +-
ui/pages/tabs/storage.html.tmpl | 6 +-
ui/pages/tabs/templates.html.tmpl | 2 +-
11 files changed, 153 insertions(+), 107 deletions(-)
_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>