<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Looks good for me.<br>
<br>
But we need to allow change the VM permissions when it is running<br>
I've just tested it and it works fine using the REST API.<br>
<br>
My suggestion is replace the "Manage Media" menu option to "Edit"
when VM is running.<br>
And add the same tab layout there. One tab for "Storage" - to manage
media, and other one for "Permission"<br>
Also it would be good to have the same layout on "Storage" tab we
have when the VM is stopped.<br>
Let me know how much is needed to have it done so we can split it
into smaller tasks or drop this to sprint 2.<br>
<br>
And if you don't mind, I have one more suggestion to make. <br>
Add the same column headers to the selected users/groups box.<br>
<br>
<br>
<img src="cid:part1.01000103.03090200@linux.vnet.ibm.com" alt=""><br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 07/22/2014 06:33 AM,
<a class="moz-txt-link-abbreviated" href="mailto:huoyuxin@linux.vnet.ibm.com">huoyuxin@linux.vnet.ibm.com</a> wrote:<br>
</div>
<blockquote
cite="mid:1406021591-300-1-git-send-email-huoyuxin@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Yu Xin Huo <a class="moz-txt-link-rfc2396E" href="mailto:huoyuxin@linux.vnet.ibm.com"><huoyuxin@linux.vnet.ibm.com></a>
Yu Xin Huo (2):
Add users/groups to VM
po files update for permission
po/en_US.po | 9 +++
po/kimchi.pot | 9 +++
po/pt_BR.po | 9 +++
po/zh_CN.po | 9 +++
ui/css/theme-default/guest-edit.css | 116 +++++++++++++++++++++++++++++++++++
ui/images/theme-default/group.png | Bin 0 -> 1703 bytes
ui/images/theme-default/user.png | Bin 0 -> 1322 bytes
ui/js/src/kimchi.api.js | 28 ++++++++
ui/js/src/kimchi.guest_edit_main.js | 112 ++++++++++++++++++++++++++++++++-
ui/pages/guest-edit.html.tmpl | 37 +++++++++++
10 files changed, 326 insertions(+), 3 deletions(-)
create mode 100644 ui/images/theme-default/group.png
create mode 100644 ui/images/theme-default/user.png
_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>