<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 7/22/2014 1:28 AM, Aline Manera
wrote:<br>
</div>
<blockquote cite="mid:53CD4DD3.6080402@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
General comments:<br>
<br>
1) I'd like to edit the VM permission when it is running<br>
I think it is possible but it is good to have a input from the
original authors - Sheldon and Cristian<br>
<br>
Sheldon, Cristian, is it possible to set the metadata element
to a running VM?<br>
<br>
2) Some suggestions about it UI<br>
<br>
* Update the labels to: "Available system users and groups" and
"Selected system users and groups"<br>
</blockquote>
addressed in v2.<br>
<blockquote cite="mid:53CD4DD3.6080402@linux.vnet.ibm.com"
type="cite"> <br>
* I think it would be good to insert some instructions to user
like:<br>
<br>
"Select system users and groups to have full access to this
virtual machine"<br>
</blockquote>
in sprint 2, when adding a user to vm, there are 2 roles: admin or
user.<br>
then this message will be redundant and does not match overall
design.<br>
<blockquote cite="mid:53CD4DD3.6080402@linux.vnet.ibm.com"
type="cite"> <br>
* I needed some time to understand that one column is a user list
and other one the group list<br>
Maybe add headers to the columns<br>
</blockquote>
addressed in v2<br>
<blockquote cite="mid:53CD4DD3.6080402@linux.vnet.ibm.com"
type="cite"> <br>
<br>
<img src="cid:part1.07050607.06000208@linux.vnet.ibm.com" alt=""><br>
<br>
<br>
<div class="moz-cite-prefix">On 07/18/2014 07:14 AM, <a
moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:huoyuxin@linux.vnet.ibm.com">huoyuxin@linux.vnet.ibm.com</a>
wrote:<br>
</div>
<blockquote
cite="mid:1405678481-31531-1-git-send-email-huoyuxin@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Yu Xin Huo <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:huoyuxin@linux.vnet.ibm.com"><huoyuxin@linux.vnet.ibm.com></a>
Yu Xin Huo (2):
Add users/groups to VM
update po
po/en_US.po | 9 +++
po/kimchi.pot | 9 +++
po/pt_BR.po | 39 ++++++++-----
po/zh_CN.po | 9 +++
ui/css/theme-default/guest-edit.css | 106 +++++++++++++++++++++++++++++++++
ui/images/theme-default/group.png | Bin 0 -> 1703 bytes
ui/images/theme-default/user.png | Bin 0 -> 1322 bytes
ui/js/src/kimchi.api.js | 28 +++++++++
ui/js/src/kimchi.guest_edit_main.js | 112 ++++++++++++++++++++++++++++++++++-
ui/pages/guest-edit.html.tmpl | 33 ++++++++++
10 files changed, 327 insertions(+), 18 deletions(-)
create mode 100644 ui/images/theme-default/group.png
create mode 100644 ui/images/theme-default/user.png
_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>