<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 07/24/2014 06:06 AM, Yu Xin Huo
wrote:<br>
</div>
<blockquote cite="mid:53D0CC96.40106@linux.vnet.ibm.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 7/22/2014 10:13 PM, Aline Manera
wrote:<br>
</div>
<blockquote cite="mid:53CE71A2.20806@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
Looks good for me.<br>
<br>
But we need to allow change the VM permissions when it is
running<br>
I've just tested it and it works fine using the REST API.<br>
<br>
My suggestion is replace the "Manage Media" menu option to
"Edit" when VM is running.<br>
And add the same tab layout there. One tab for "Storage" - to
manage media, and other one for "Permission"<br>
Also it would be good to have the same layout on "Storage" tab
we have when the VM is stopped.<br>
Let me know how much is needed to have it done so we can split
it into smaller tasks or drop this to sprint 2.<br>
</blockquote>
Aline, If I understand correctly, you mean below:<br>
1. add a new tab(manage media) in vm edit to remove the 'manage
media' menu item in Actions dropdown.<br>
2. the 'manage media' only available when vm is started.<br>
3. for the content of 'manage media', it should take the same
layout as storage tab.<br>
</blockquote>
<br>
Partial correctly. :-)<br>
<br>
I want to also have a "Edit" action when the VM is running.<br>
This "Edit" would open a dialog (like it is when the VM is stopped)
but display only 2 tabs: "Manage Media" and "Permission"<br>
<br>
So the edit dialog should be build dynamically according to VM state:<br>
<br>
- state == running: display "Manage Media" and "Permission" tabs<br>
- state == stopped: display all tabs we do today<br>
<br>
Does that make more sense now?<br>
<br>
<br>
<blockquote cite="mid:53D0CC96.40106@linux.vnet.ibm.com" type="cite">
<blockquote cite="mid:53CE71A2.20806@linux.vnet.ibm.com"
type="cite"> <br>
And if you don't mind, I have one more suggestion to make. <br>
Add the same column headers to the selected users/groups box.<br>
</blockquote>
Addressed in V3.<br>
<blockquote cite="mid:53CE71A2.20806@linux.vnet.ibm.com"
type="cite"> <br>
<br>
<img src="cid:part1.00060901.06040901@linux.vnet.ibm.com" alt=""><br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 07/22/2014 06:33 AM, <a
moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:huoyuxin@linux.vnet.ibm.com">huoyuxin@linux.vnet.ibm.com</a>
wrote:<br>
</div>
<blockquote
cite="mid:1406021591-300-1-git-send-email-huoyuxin@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Yu Xin Huo <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:huoyuxin@linux.vnet.ibm.com"><huoyuxin@linux.vnet.ibm.com></a>
Yu Xin Huo (2):
Add users/groups to VM
po files update for permission
po/en_US.po | 9 +++
po/kimchi.pot | 9 +++
po/pt_BR.po | 9 +++
po/zh_CN.po | 9 +++
ui/css/theme-default/guest-edit.css | 116 +++++++++++++++++++++++++++++++++++
ui/images/theme-default/group.png | Bin 0 -> 1703 bytes
ui/images/theme-default/user.png | Bin 0 -> 1322 bytes
ui/js/src/kimchi.api.js | 28 ++++++++
ui/js/src/kimchi.guest_edit_main.js | 112 ++++++++++++++++++++++++++++++++-
ui/pages/guest-edit.html.tmpl | 37 +++++++++++
10 files changed, 326 insertions(+), 3 deletions(-)
create mode 100644 ui/images/theme-default/group.png
create mode 100644 ui/images/theme-default/user.png
_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>