<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 08/12/2014 02:41 AM, Crístian Viana wrote:
<blockquote cite="mid:53E90E68.9020604@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 11-08-2014 11:22, <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:shaohef@linux.vnet.ibm.com">shaohef@linux.vnet.ibm.com</a>
wrote:<br>
<blockquote
cite="mid:1407766943-9178-1-git-send-email-shaohef@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: ShaoHe Feng <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:shaohef@linux.vnet.ibm.com"><shaohef@linux.vnet.ibm.com></a>
We don not need a special "save" button for permission form.
All form in guest edit tab can share the same "save" button.
also, we will add a password form, it will also share this button.
Signed-off-by: ShaoHe Feng <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:shaohef@linux.vnet.ibm.com"><shaohef@linux.vnet.ibm.com></a>
Signed-off-by: Simon Jin <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:simonjin@linux.vnet.ibm.com"><simonjin@linux.vnet.ibm.com></a>
</pre>
</blockquote>
Why are we using a save button for each tab in that dialog? That's
definitely not a common user experience. One would expect that a
"Save" button in that dialog would apply all changes done in the
dialog, not on that tab alone. What if the user wants to change
the VM name and permission (and the password, after the next
patch)? They will need to open the "Edit Guest" dialog, changing
the value they want to change, and then saving that value alone. <i>Three
times.</i> That's not a good flow.<br>
<br>
IMO, we should have only one "Save" button which, when clicked,
applies all the changes done in that dialog. Not a button which
does different things depending on which tab the user is on.<br>
</blockquote>
That's not always true, at least on virt-manager.<br>
one thing can be improved here is to disable the "save" button when
there isn't having any change on the tab yet and enable it when
there is.<br>
<br>
-Simon<br>
<blockquote cite="mid:53E90E68.9020604@linux.vnet.ibm.com"
type="cite">
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Yun Tong Jin, Simon
Linux Technology Center, Open Virtualization project
IBM Systems & Technology Group
<a class="moz-txt-link-abbreviated" href="mailto:jinyt@cn.ibm.com">jinyt@cn.ibm.com</a>, Phone: 824549654 </pre>
</body>
</html>