<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I've fixed the part of the patch that breaks it and will send a v2.<br>
<br>
However, I must say that make check does not complete successfully
in master due to failures/errors that this patch can't and shouldn't
be accounted for:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
======================================================================<br>
ERROR: test_delete_running_vm (test_model.ModelTests)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 1062, in test_delete_running_vm<br>
inst.templates_create(params)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create<br>
user = UserTests().probe_user()<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py",
line 56, in probe_user<br>
dom.create()<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in
create<br>
if ret == -1: raise libvirtError ('virDomainCreate() failed',
dom=self)<br>
libvirtError: monitor socket did not show up: No such file or
directory<br>
<br>
======================================================================<br>
ERROR: test_template_clone (test_model.ModelTests)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 693, in test_template_clone<br>
inst.templates_create(orig_params)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create<br>
user = UserTests().probe_user()<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py",
line 56, in probe_user<br>
dom.create()<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in
create<br>
if ret == -1: raise libvirtError ('virDomainCreate() failed',
dom=self)<br>
libvirtError: monitor socket did not show up: No such file or
directory<br>
<br>
======================================================================<br>
ERROR: test_template_create (test_model.ModelTests)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 613, in test_template_create<br>
self.assertRaises(InvalidParameter, inst.templates_create,
params)<br>
File "/usr/lib64/python2.7/unittest/case.py", line 513, in
assertRaises<br>
callableObj(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/templates.py",
line 45, in create<br>
user = UserTests().probe_user()<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/kvmusertests.py",
line 56, in probe_user<br>
dom.create()<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/libvirtconnection.py",
line 62, in wrapper<br>
ret = f(*args, **kwargs)<br>
File "/usr/lib64/python2.7/site-packages/libvirt.py", line 698, in
create<br>
if ret == -1: raise libvirtError ('virDomainCreate() failed',
dom=self)<br>
libvirtError: monitor socket did not show up: No such file or
directory<br>
<br>
======================================================================<br>
ERROR: test_vm_cdrom (test_model.ModelTests)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 400, in test_vm_cdrom<br>
cdrom_dev = inst.vmstorages_create(vm_name, cdrom_args)<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vmstorages.py",
line 178, in create<br>
raise OperationFailed("KCHVMSTOR0008E", {'error': e.message})<br>
OperationFailed: KCHVMSTOR0008E: Error while creating new storage
device: internal error unknown protocol type 'http'<br>
<br>
======================================================================<br>
ERROR: test_vm_lifecycle (test_model.ModelTests)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 101, in test_vm_lifecycle<br>
inst.vm_start('kimchi-vm')<br>
File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vms.py",
line 542, in start<br>
{'name': name, 'err': e.get_error_message()})<br>
OperationFailed: KCHVM0019E: Unable to start virtual machine
kimchi-vm. Details: monitor socket did not show up: No such file or
directory<br>
<br>
======================================================================<br>
FAIL: test_debug_reports (test_model.ModelTests)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "/home/danielhb/kimchi/kimchi-upstream/tests/test_model.py",
line 1151, in test_debug_reports<br>
"It is not necessary an error. "<br>
AssertionError: It is not necessary an error. You may need to
increase the timeout number by TEST_REPORT_TIMEOUT=200
./run_tests.sh test_model<br>
<br>
----------------------------------------------------------------------<br>
Ran 161 tests in 357.586s<br>
<br>
FAILED (failures=1, errors=5, skipped=2)<br>
<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 08/19/2014 12:12 PM, Crístian Viana
wrote:<br>
</div>
<blockquote cite="mid:53F36947.9030207@linux.vnet.ibm.com"
type="cite">This patch breaks the tests. Please run "make check"
before submitting patches.
<br>
<br>
On 19-08-2014 11:49, Daniel Henrique Barboza wrote:
<br>
<blockquote type="cite">As described in Github issue #354, this
patch filters the storage
<br>
targets list to not show the nfs paths that are in use by an
<br>
existing NFS pool.
<br>
<br>
Signed-off-by: Daniel Henrique Barboza
<a class="moz-txt-link-rfc2396E" href="mailto:danielhb@linux.vnet.ibm.com"><danielhb@linux.vnet.ibm.com></a>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>