<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 08/27/2014 04:27 PM, Rodrigo
Trujillo wrote:<br>
</div>
<blockquote cite="mid:53FE310D.4040907@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi, I tested the patches and they
worked when I tried to attach a new iscsi LUN<br>
<br>
See screenshot attached:<br>
- vda is an iSCSI LUN unit:0:0:2 added to vm during its creation
- it is a disk of type VOLUME<br>
* NOTICE that path is different because I am using the patch
I wrote and sent in "[Kimchi-devel] [PATCH] Fix guest<br>
disk return when disk is a iscsi volume" . Otherwise, the
path would be blank<br>
- vdb is an iSCSI LUN unit:0:0:1 added using this patch from
Royce <br>
<br>
Problem is that disks based on iSCSI LUNs are being created
differently, generating diferent XMLs. See:<br>
</div>
</blockquote>
<br>
I've just sent a patch to fix this problem and make the volume XML
the same in both cases.<br>
Check: [Kimchi-devel] [PATCH] Update iSCSI volume XML when creating
a VM from an iSCSI pool<br>
<br>
<blockquote cite="mid:53FE310D.4040907@linux.vnet.ibm.com"
type="cite">
<div class="moz-cite-prefix"> <br>
<div class="syntax">
<div class="text" style="font-family: monospace;">
<ol>
<li class="li1">
<div class="de1"> <disk type='volume'
device='disk'></div>
</li>
<li class="li2">
<div class="de2"> <driver name='qemu'
type='raw'/></div>
</li>
<li class="li1">
<div class="de1"> <source pool='TEST-ISCSI1'
volume='unit:<span class="nu0">0</span>:<span
class="nu0">0</span>:<span class="nu0">2</span>'
mode='host'/></div>
</li>
<li class="li2">
<div class="de2"> <target dev='vda'
bus='virtio'/></div>
</li>
<li class="li1">
<div class="de1"> <address type='pci'
domain='0x0000' bus='0x00' slot='0x05'
function='0x0'/></div>
</li>
<li class="li2">
<div class="de2"> </disk></div>
</li>
<li class="li1">
<div class="de1"> <disk type='block'
device='disk'></div>
</li>
<li class="li2">
<div class="de2"> <driver name='qemu'
type='raw'/></div>
</li>
<li class="li1">
<div class="de1"> <source
dev='/dev/disk/by-id/wwn-0x60000000000000000e00000000010001'/></div>
</li>
<li class="li2">
<div class="de2"> <target dev='vdb'
bus='virtio'/></div>
</li>
<li class="li1">
<div class="de1"> <address type='pci'
domain='0x0000' bus='0x00' slot='0x07'
function='0x0'/></div>
</li>
<li class="li2">
<div class="de2"> </disk></div>
</li>
<li class="li1">
<div class="de1"> <disk type='network'
device='cdrom'></div>
</li>
<li class="li2">
<div class="de2"> <driver name='qemu'
type='raw'/></div>
</li>
<li class="li1">
<div class="de1"> <source protocol='http'
name='/pub/fedora/releases/<span class="nu0">20</span>/Live/x86_64/Fedora-Live-Desktop-x86_64<span
class="nu0">-20</span><span class="nu0">-1</span>.iso'></div>
</li>
<li class="li2">
<div class="de2"> <host name='<span
class="nu0">204.246</span><span class="nu0">.0</span><span
class="nu0">.137</span>' port='<span class="nu0">80</span>'/></div>
</li>
<li class="li1">
<div class="de1"> </source></div>
</li>
<li class="li2">
<div class="de2"> <target dev='hdc'
bus='ide'/></div>
</li>
<li class="li1">
<div class="de1"> <readonly/></div>
</li>
<li class="li2">
<div class="de2"> <address type='drive'
controller='<span class="nu0">0</span>' bus='<span
class="nu0">1</span>' target='<span class="nu0">0</span>'
unit='<span class="nu0">0</span>'/></div>
</li>
<li class="li1">
<div class="de1"> </disk> </div>
</li>
</ol>
</div>
</div>
<br>
So, we need to agree about which xml type are we going to use
when attaching an iSCSI Lun: VOLUME or BLOCK ?<br>
Once decided, implement similarly when creating VM and when
attaching new storage.<br>
Then fix the UI if needed. <br>
<br>
Regards<br>
<br>
Rodrigo Trujillo<br>
<br>
<br>
On 08/26/2014 06:50 AM, <a moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:lvroyce@linux.vnet.ibm.com">lvroyce@linux.vnet.ibm.com</a>
wrote:<br>
</div>
<blockquote
cite="mid:1409046602-1370-1-git-send-email-lvroyce@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Royce Lv <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:lvroyce@linux.vnet.ibm.com"><lvroyce@linux.vnet.ibm.com></a>
Iscsi volume fails to attach to vm because of its path is rejected
by previous cdrom validate logic,
and type 'unknown' forms wrong vm xml
This patchset fix the above bugs and form right vm xml in order to
start vm.
Royce Lv (2):
Guest storage: Fix attaching type judgement
Guest storage: fix volume format overwrite
src/kimchi/model/vmstorages.py | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>