<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
After testing the patch set I got only one error in the following
test:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<ol style="color: rgb(0, 0, 0); font-family: 'Liberation Sans',
'Lucida Grande', 'Luxi Sans', 'Bitstream Vera Sans', helvetica,
verdana, arial, sans-serif; font-size: 12px; font-style: normal;
font-variant: normal; font-weight: normal; letter-spacing: normal;
line-height: normal; orphans: auto; text-align: left; text-indent:
0px; text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255);">
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">======================================================================</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">ERROR:
test_nonroot_access (test_authorization.AuthorizationTests)</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">----------------------------------------------------------------------</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">Traceback
(most recent call last):</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;"> File
"test_authorization.py", line 124, in test_nonroot_access</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">
'groups': []})</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;"> File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vms.py",
line 277, in update</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">
self._live_vm_update(dom, params)</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;"> File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vms.py",
line 668, in _live_vm_update</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">
self._vm_update_access_metadata(dom, params)</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;"> File
"/home/danielhb/kimchi/kimchi-upstream/src/kimchi/model/vms.py",
line 556, in _vm_update_access_metadata</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">
{'users': ", ".join(invalid_users)})</div>
</li>
<li style="font-weight: normal; vertical-align: top;">
<div style="font-style: normal; font-variant: normal;
font-weight: normal; font-stretch: normal; font-size: 1em;
line-height: 1.2em; font-family: monospace; margin: 0px;
padding: 0px; vertical-align: top; background: none;">InvalidParameter:
KCHVM0027E: User(s) 'admin' do not exist</div>
</li>
</ol>
<br>
My guess is that the user 'admin' is being passed forward to the
_vm_update method while I do not<br>
have the 'admin' user in my system. <br>
<br>
<br>
Thanks!<br>
<br>
<div class="moz-cite-prefix">On 11/11/2014 06:46 PM, Aline Manera
wrote:<br>
</div>
<blockquote
cite="mid:1415738788-22458-1-git-send-email-alinefm@linux.vnet.ibm.com"
type="cite">
<pre wrap="">Yeap! Finally it is done!
The new MockModel uses Model with the 'test:///default' URI.
I also needed to update some tests cases and the run_tests.sh.in scripts as
the new MockModel overrides some Model functions, the test_model.py must be the
first test to be run.
But there are one test that is still failing:
======================================================================
FAIL: test_edit_vm (test_rest.RestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "test_rest.py", line 248, in test_edit_vm
self.assertEquals('123456', info["graphics"]["passwd"])
AssertionError: '123456' != u'abcdef'
I could not identify the reason yet, as the same test runs fine when I only run
test_rest.py. I suspect it is a override issue.
While I am investigating it I decided to send the patches to collect feedbacks
soon.
Aline Manera (6):
Re-raise the original exception when creating a new Template
Use objectify to Remove metadata namespace
Check currentMemory exists prior to remote its XML node
Ensure the guest volume exists to remove it
Pass libvirt connection as CapabilitiesModel parameter
MockModel refactor: Create MockModel based on Model("test:///default")
src/kimchi/mockmodel.py | 1769 +++++++-----------------------------
src/kimchi/model/host.py | 3 +-
src/kimchi/model/storagepools.py | 2 +-
src/kimchi/model/storagetargets.py | 2 +-
src/kimchi/model/templates.py | 5 +-
src/kimchi/model/utils.py | 37 +-
src/kimchi/model/vmhostdevs.py | 3 +-
src/kimchi/model/vmifaces.py | 5 +-
src/kimchi/model/vms.py | 44 +-
src/kimchi/model/vmstorages.py | 16 +-
src/kimchi/vmtemplate.py | 9 +-
tests/run_tests.sh.in | 18 +-
tests/test_authorization.py | 25 +-
tests/test_mockmodel.py | 60 +-
tests/test_rest.py | 254 +++---
15 files changed, 565 insertions(+), 1687 deletions(-)
</pre>
</blockquote>
<br>
</body>
</html>