<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Here are my comments on this patch:<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
- When I open the dialog "Edit" on a VM without snapshots, the error
KCHSNAP0007E* is shown. That's because the VM doesn't have snapshots
but the UI should handle that and do nothing. Not having snapshots
is not an error from the UI perspective.<br>
<br>
- I cannot create a snapshot at all. Whenever I click on the button
'+', the error "KCHAPI0006E: Unable to parse JSON request" is shown.<br>
<br>
- I cannot revert to the current snapshot. The button "Revert"
becomes disabled whenever the current snapshot is selected. And
that's a very important use case. Suppose I just created a snapshot.
Then I mistakenly removed some files on my guest system and I want
to revert to that snapshot. With the current UI, I'm not able to do
that.<br>
<br>
- There's no visual feedback when I click on the button "Revert".
When I click on it and the revert operation starts, nothing happens.
The user might click on it again thinking that the button wasn't
clicked on the first time. Also there's no way to know if the revert
operation finished.<br>
<br>
- If the user clicks on the button "Revert", closes the dialog
"Edit" and reopens it while the revert operation is still happening,
the error KCHSNAP0007E* is shown and the tab "Snapshot" is rendered
empty, even if there are snapshots to be listed on the VM. The same
problem also happens when the user clicks on the button with the
trash can, instead of "Revert", and closes the dialog and reopens it
while the operation hasn't finished.<br>
<br>
- Why isn't there a button "Revert" on each snapshot line? The
button with the trash can is there, the button "Revert" should also
be there. That's an action that applies to only one snapshot at a
time, just like delete. Other actions in other tabs, like "Edit",
are also shown on the relevant line instead of at the top of the
dialog. The button "+" is different, though, because it doesn't act
in one entry alone, it acts on the whole set of items. So that makes
sense for me to be at the top.<br>
<br>
* Actually, the backend is raising the exception code KCHSNAP007E
(i.e. there's one '0' less), which is an invalid code. I'll send a
patch later to fix that. But the UI shouldn't worry about that
because the REST command returns the status code 404 in that case
anyway.<br>
<br>
<div class="moz-cite-prefix">On 17-11-2014 09:12,
<a class="moz-txt-link-abbreviated" href="mailto:huoyuxin@linux.vnet.ibm.com">huoyuxin@linux.vnet.ibm.com</a> wrote:<br>
</div>
<blockquote
cite="mid:1416222742-17408-1-git-send-email-huoyuxin@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Yu Xin Huo <a class="moz-txt-link-rfc2396E" href="mailto:huoyuxin@linux.vnet.ibm.com"><huoyuxin@linux.vnet.ibm.com></a>
Signed-off-by: Yu Xin Huo <a class="moz-txt-link-rfc2396E" href="mailto:huoyuxin@linux.vnet.ibm.com"><huoyuxin@linux.vnet.ibm.com></a>
</pre>
</blockquote>
</body>
</html>