<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Some style comments:<br>
<br>
1. Storage, Network and Permission (when ldap) tabs will have a
similar layout so all those 3 tabs should share the same margin and
alignment values.<br>
<br>
Network and Storage differs on margins values.<br>
<br>
<img src="cid:part1.06050206.05050809@linux.vnet.ibm.com" alt=""><br>
<br>
<br>
<img src="cid:part2.04060808.08020507@linux.vnet.ibm.com" alt=""><br>
<br>
<br>
The Permission tab differs on margin and alignment from the other 2.<br>
Also the plus icon is over the line.<br>
<br>
<br>
<img src="cid:part3.06020607.04020201@linux.vnet.ibm.com" alt=""><br>
<br>
So I'd suggest to have those margin and alignment values shared in
all those 3 tabs.<br>
<br>
2. I think the user input box (when I select the plus icon on
Permission tab) should be bigger, like 2x the current width<br>
<br>
<br>
<div class="moz-cite-prefix">On 11/20/2014 08:22 AM,
<a class="moz-txt-link-abbreviated" href="mailto:lvroyce@linux.vnet.ibm.com">lvroyce@linux.vnet.ibm.com</a> wrote:<br>
</div>
<blockquote
cite="mid:1416478927-8595-1-git-send-email-lvroyce@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Royce Lv <a class="moz-txt-link-rfc2396E" href="mailto:lvroyce@linux.vnet.ibm.com"><lvroyce@linux.vnet.ibm.com></a>
v1>v2,
Change according to backend API change.
Royce Lv (2):
UI: support ldap vm permission tag
Change guest edit permission logic
ui/css/theme-default/guest-edit.css | 79 +++++++---
ui/js/src/kimchi.api.js | 15 +-
ui/js/src/kimchi.guest_edit_main.js | 300 ++++++++++++++++++++++++------------
ui/pages/guest-edit.html.tmpl | 28 +++-
4 files changed, 299 insertions(+), 123 deletions(-)
</pre>
</blockquote>
<br>
</body>
</html>