<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 06/01/2015 13:40, Aline Manera
wrote:<br>
</div>
<blockquote cite="mid:54AC01F4.5080407@linux.vnet.ibm.com"
type="cite">
<br>
On 06/01/2015 10:03, Daniel Henrique Barboza wrote:
<br>
<blockquote type="cite">Running the ./run-tests.sh script with
these patches in my machine (Lenovo T410 with Fedora 20) gives
the following error:
<br>
<br>
<br>
======================================================================
<br>
FAIL: test_network_lifecycle (test_network.NetworkTests)
<br>
----------------------------------------------------------------------
<br>
Traceback (most recent call last):
<br>
File "test_network.py", line 148, in test_network_lifecycle
<br>
_do_test(net)
<br>
File "test_network.py", line 101, in _do_test
<br>
self.assertEquals(201, resp.status)
<br>
AssertionError: 201 != 400
<br>
<br>
----------------------------------------------------------------------
<br>
<br>
<br>
I made sure to run make clean // autogen.sh --system // make
after applying the patches. Removing the patches fixes this
behavior.
<br>
<br>
Hope it helps!
<br>
<br>
</blockquote>
<br>
Thanks for checking it, Daniel!
<br>
<br>
I verified the test case and it is failing because I assumed in
the test case any interface would be good to create a bridged
network which is not always true.
<br>
<br>
So I will remove the below code and send the V2
<br>
<br>
+ # Verify the current system has at least one interface to
create a
<br>
+ # bridged network
<br>
</blockquote>
<br>
<blockquote cite="mid:54AC01F4.5080407@linux.vnet.ibm.com"
type="cite">+ interfaces =
json.loads(self.request('/interfaces').read())
<br>
</blockquote>
<br>
Daniel, could you please check if changing change the above line to<br>
<br>
interfaces = json.loads(self.request('/interfaces<b>?type=nic</b>').read())
<br>
<br>
fix the issue you had?<br>
<br>
Thanks<br>
Aline Manera<br>
<br>
<br>
<blockquote cite="mid:54AC01F4.5080407@linux.vnet.ibm.com"
type="cite">+ if len(interfaces) > 0:
<br>
+ iface = interfaces[0]['name']
<br>
+ networks.append({'name': u'bridge-network',
'connection': 'bridge',
<br>
+ 'interface': iface})
<br>
+ networks.append({'name': u'vlan-network',
'connection': 'bridge',
<br>
+ 'interface': iface, 'vlan_id': 999})
<br>
<br>
<br>
<blockquote type="cite">Daniel
<br>
<br>
<br>
On 12/29/2014 12:53 PM, Aline Manera wrote:
<br>
<blockquote type="cite">Aline Manera (5):
<br>
Add message to KCHNET0010E code
<br>
Bug fix: Allow deleting VLAN tagging bridged network
<br>
Network API: Update docs/API.md
<br>
Move rollback_wrapper function to a common place
<br>
Reorganize the network tests
<br>
<br>
docs/API.md | 11 ++--
<br>
src/kimchi/i18n.py | 1 +
<br>
src/kimchi/model/networks.py | 6 +-
<br>
tests/test_model.py | 86 ++-----------------------
<br>
tests/test_network.py | 147
+++++++++++++++++++++++++++++++++++++++++++
<br>
tests/test_rest.py | 64 -------------------
<br>
tests/utils.py | 15 ++++-
<br>
7 files changed, 175 insertions(+), 155 deletions(-)
<br>
create mode 100644 tests/test_network.py
<br>
<br>
</blockquote>
<br>
_______________________________________________
<br>
Kimchi-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
<br>
<br>
</blockquote>
<br>
_______________________________________________
<br>
Kimchi-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
<br>
<br>
</blockquote>
<br>
</body>
</html>