<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 07-01-2015 23:38, Zongmei Gou wrote:<br>
<blockquote
cite="mid:3afd149c.13bd3.14ac731afab.Coremail.gouzongmei@163.com"
type="cite">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial"><font
class="" size="3"><span style="font-family: Times New
Roman; font-size: 18px;">1. snap.listAllChildren() in
_backup_snapshots.py need flag in older libvirt
versions, as I used "0.10.2", it raised
"listAllChildren() takes exactly 2 arguments (1 given)"
</span></font><br>
<br>
</div>
</div>
</div>
</blockquote>
Great! I'll fix that.<br>
<br>
<blockquote
cite="mid:3afd149c.13bd3.14ac731afab.Coremail.gouzongmei@163.com"
type="cite">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial">
<div
style="line-height:1.7;color:#000000;font-size:14px;font-family:Arial"><font
class="" size="3"><span style="font-family: Times New
Roman; font-size: 18px;">2. UI transfer param 'name' no
matter you update vm name or not (of course while you
edit a vm), so do we only need to bakup and restore the
snapshots while vm name is really updated ? </span></font><br>
</div>
</div>
</div>
</blockquote>
<br>
Well, IMO that's a UI bug. The UI shouldn't send the parameter
'name' when the VM name isn't changed. I think we should keep our
patches like this (i.e. updating only the fields explicitly passed)
and the UI should be updated later so it works better under the
hood.<br>
<br>
I'll send the patch with the fix (1) above.<br>
</body>
</html>