<div dir="ltr">Reviewed-by: Crístian Deives &lt;<a href="mailto:cristiandeives@gmail.com">cristiandeives@gmail.com</a>&gt;<br></div><br><div class="gmail_quote">On Wed, May 20, 2015 at 12:49 PM Paulo Ricardo Paz Vital &lt;<a href="mailto:pvital@gmail.com">pvital@gmail.com</a>&gt; wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Reviewed-by: Paulo Vital &lt;<a href="mailto:pvital@gmail.com" target="_blank">pvital@gmail.com</a>&gt;<br>
<br>
&gt; On 20 May 2015, at 12:18, Rodrigo Trujillo &lt;<a href="mailto:rodrigo.trujillo@linux.vnet.ibm.com" target="_blank">rodrigo.trujillo@linux.vnet.ibm.com</a>&gt; wrote:<br>
&gt;<br>
&gt; This patch fixes a bug in interfaces.py. A parenthesis is missing, so<br>
&gt; when the user tries to create a SLES ppc64 guest, kimchi is going to<br>
&gt; raise the error:<br>
&gt; AttributeError: &#39;unicode&#39; object has no attribute &#39;version&#39;<br>
&gt;<br>
&gt; Signed-off-by: Rodrigo Trujillo &lt;<a href="mailto:rodrigo.trujillo@linux.vnet.ibm.com" target="_blank">rodrigo.trujillo@linux.vnet.ibm.com</a>&gt;<br>
&gt; ---<br>
&gt; src/kimchi/xmlutils/interface.py | 2 +-<br>
&gt; 1 file changed, 1 insertion(+), 1 deletion(-)<br>
&gt;<br>
&gt; diff --git a/src/kimchi/xmlutils/interface.py b/src/kimchi/xmlutils/interface.py<br>
&gt; index f725821..82ac505 100644<br>
&gt; --- a/src/kimchi/xmlutils/interface.py<br>
&gt; +++ b/src/kimchi/xmlutils/interface.py<br>
&gt; @@ -56,7 +56,7 @@ def get_iface_xml(params, arch=None, os_distro=None, os_version=None):<br>
&gt;        ((os_distro == &#39;ubuntu&#39; and<br>
&gt;          LooseVersion(os_version) &gt;= LooseVersion(&#39;14.04&#39;)) or<br>
&gt;         (os_distro == &#39;sles&#39; and<br>
&gt; -         LooseVersion(os_version &gt;= LooseVersion(&#39;12&#39;)))):<br>
&gt; +         LooseVersion(os_version) &gt;= LooseVersion(&#39;12&#39;))):<br>
&gt;         interface.append(E.driver(name=&#39;qemu&#39;))<br>
&gt;<br>
&gt;     return ET.tostring(interface, encoding=&#39;utf-8&#39;, pretty_print=True)<br>
&gt; --<br>
&gt; 2.1.0<br>
&gt;<br>
&gt; _______________________________________________<br>
&gt; Kimchi-devel mailing list<br>
&gt; <a href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a><br>
&gt; <a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a><br>
<br>
_______________________________________________<br>
Kimchi-devel mailing list<br>
<a href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a><br>
</blockquote></div>