<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 08/06/2015 04:40 PM, Harshal Patil
wrote:<br>
</div>
<blockquote
cite="mid:201508061941.t76JfP0a020843@d28av05.in.ibm.com"
type="cite">
<div class="socmaildefaultfont" dir="ltr"
style="font-family:Arial;font-size:10.5pt">
<div dir="ltr">Any reason for not using pull requests? for me it
gives a better interface for the discussion. Better (but very
basic) code review tool too. </div>
<div dir="ltr"> </div>
</div>
</blockquote>
<br>
I do not have anything against pull requests. Feel free to send the
pull request link for the changes<br>
you want review in the cover page of the plain-text patches.<br>
<br>
<blockquote
cite="mid:201508061941.t76JfP0a020843@d28av05.in.ibm.com"
type="cite">
<div class="socmaildefaultfont" dir="ltr"
style="font-family:Arial;font-size:10.5pt">
<div dir="ltr">Can anyone explain to me what projects like
Docker are doing wrong by using pull requests?</div>
</div>
<br>
</blockquote>
They're doing nothing wrong. I was a maintainer of a Eclipse
Linuxtools plug-in and they use pull<br>
requests too. It works.<br>
<br>
The reason why Kimchi (and Ginger, for that matter) uses plain-text
patches in the mailing list<br>
is simplicity. You can easily quote and comment specific parts of
the patch using standard<br>
email tools. I have kimchi and ginger source code in Power
environments for testing and more<br>
than once I've sent patches directly from a Power host and reviewed
them in pine. <br>
<br>
Using pull requests for code review implies that I need to open
github, review the patch<br>
there, comment the patch there and so on. It adds one step and drags
away the discussing<br>
from the ML. And, unless you want to keep refreshing the pull
request URL in the browser,<br>
you'll want an email notifying that your changes went upstream. Even
if github notifies that<br>
automatically to you, other people might be interested in the status
of those changes too.<br>
<br>
TL;DR it is a matter of culture and Kimchi/Ginger was developed
under the plain-text<br>
git-sendmail paradigm.<br>
<br>
<br>
<br>
<br>
<blockquote
cite="mid:201508061941.t76JfP0a020843@d28av05.in.ibm.com"
type="cite">
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>