<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial;font-size:10.5pt" ><div dir="ltr" >Thanks Dan for that clarification. As you put it correctly, it's a matter of a culture that one is used to. </div>
<div dir="ltr" > </div>
<div dir="ltr" > </div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr" >----- Original message -----<br>From: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com><br>Sent by: kimchi-devel-bounces@ovirt.org<br>To: kimchi-devel@ovirt.org<br>Cc:<br>Subject: Re: [Kimchi-devel] Why not to use github pull requests?<br>Date: Fri, Aug 7, 2015 1:44 AM<br> <br><!--Notes ACF
<meta content="text/html; charset=utf8"
http-equiv="Content-Type" >--><br>
<div>On 08/06/2015 04:40 PM, Harshal Patil wrote:</div>
<blockquote cite="mid:201508061941.t76JfP0a020843@d28av05.in.ibm.com" type="cite" ><div dir="ltr" style="font-family:Arial;font-size:10.5pt" ><div dir="ltr" >Any reason for not using pull requests? for me it gives a better interface for the discussion. Better (but very basic) code review tool too. </div>
<div dir="ltr" > </div></div></blockquote><br>I do not have anything against pull requests. Feel free to send the pull request link for the changes<br>you want review in the cover page of the plain-text patches.<br>
<blockquote cite="mid:201508061941.t76JfP0a020843@d28av05.in.ibm.com" type="cite" ><div dir="ltr" style="font-family:Arial;font-size:10.5pt" ><div dir="ltr" >Can anyone explain to me what projects like Docker are doing wrong by using pull requests?</div></div></blockquote>They're doing nothing wrong. I was a maintainer of a Eclipse Linuxtools plug-in and they use pull<br>requests too. It works.<br><br>The reason why Kimchi (and Ginger, for that matter) uses plain-text patches in the mailing list<br>is simplicity. You can easily quote and comment specific parts of the patch using standard<br>email tools. I have kimchi and ginger source code in Power environments for testing and more<br>than once I've sent patches directly from a Power host and reviewed them in pine.<br><br>Using pull requests for code review implies that I need to open github, review the patch<br>there, comment the patch there and so on. It adds one step and drags away the discussing<br>from the ML. And, unless you want to keep refreshing the pull request URL in the browser,<br>you'll want an email notifying that your changes went upstream. Even if github notifies that<br>automatically to you, other people might be interested in the status of those changes too.<br><br>TL;DR it is a matter of culture and Kimchi/Ginger was developed under the plain-text<br>git-sendmail paradigm.<br><br><br><br>
<blockquote cite="mid:201508061941.t76JfP0a020843@d28av05.in.ibm.com" type="cite" >
<fieldset> </fieldset>
<div><font face="Default Monospace,Courier New,Courier,monospace" size="2" >_______________________________________________<br>Kimchi-devel mailing list<br><a href="mailto:Kimchi-devel@ovirt.org" target="_blank" >Kimchi-devel@ovirt.org</a><br><a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" target="_blank" >http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a></font></div></blockquote>
<div><font face="Default Monospace,Courier New,Courier,monospace" size="2" >_______________________________________________<br>Kimchi-devel mailing list<br>Kimchi-devel@ovirt.org<br><a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" target="_blank" >http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a></font></div></blockquote>
<div dir="ltr" > </div></div><BR>