<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi all,<br>
<br>
Do we need to consider PEP 8 guidelines while naming the plugin ?<br>
<a class="moz-txt-link-freetext"
href="https://www.python.org/dev/peps/pep-0008/#package-and-module-names">https://www.python.org/dev/peps/pep-0008/#package-and-module-names</a><br>
<br>
I see some issue by having "-" in the python plugin naming
convention (ex: ginger-base), as import will not work directly. <br>
Example: in the consider tests/test_host.py file, which contains
statement <br>
<span class="pl-k">from</span> kimchi.mockmodel <span class="pl-k">import</span>
MockModel<br>
<br>
when moved to ginger-base plugin become<br>
<br>
<span class="pl-k">from</span> ginger-base.mockmodel <span
class="pl-k">import</span> MockModel<br>
python import will not recognize the module name with "-"<br>
<br>
I could overcome that by :<br>
<pre style="" class="lang-py prettyprint prettyprinted"><code><span class="kwd">import</span><span class="pln"> importlib
mod </span><span class="pun">=</span><span class="pln"> importlib</span><span class="pun">.</span><span class="pln">import_module</span><span class="pun">(</span><span class="str">"path.to.my-module"</span><span class="pun">)
or
</span></code><code><span class="pln">module </span><span class="pun">=</span><span class="pln"> __import__</span><span class="pun">(</span><span class="str">"</span></code><code><span class="str"><code><span class="str">path.to.my-module</span></code>"</span><span class="pun">)</span></code>
</pre>
<br>
But I feel, It is not adhering PEP 8 guidelines.<br>
<br>
So my proposal would be not to have "-" in the module name ? ie.
gingerbase, gingerppc, gingers390x etc.. if so even api has to have
the same convention ?<br>
<br>
Any better suggestions are welcome.<br>
<br>
Thanks and Regards<br>
Chandra<br>
<br>
<div class="moz-cite-prefix">On 08/12/2015 06:39 PM, Chandra
Shehkhar Reddy Potula wrote:<br>
</div>
<blockquote cite="mid:55CB4582.5060907@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Fine with me !!!<br>
<br>
<div class="moz-cite-prefix">On 08/12/2015 06:13 PM, Daniel
Henrique Barboza wrote:<br>
</div>
<blockquote cite="mid:55CB3F62.3060702@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 08/12/2015 09:08 AM, Aline
Manera wrote:<br>
</div>
<blockquote cite="mid:55CB373F.1050301@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 11/08/2015 13:27, Kevin Zander
wrote:<br>
</div>
<blockquote
cite="mid:1439310445.3434.5.camel@linux.vnet.ibm.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<div>On Tue, 2015-08-11 at 11:47 -0300, Aline Manera wrote:</div>
<blockquote type="cite"> Hi all,<br>
<br>
As we have agreed on moving the Kimchi Host tab to Ginger
community and creating a new plugin (ginger-basic), I want
to list step-by-step what we need to do *on Kimchi side*.<br>
<br>
1) Will we call this new plugin as ginger-basic? Any other
suggestion?<br>
</blockquote>
<div><br>
</div>
<div>I think keeping it as ginger is better. ginger-basic
sounds like there's ginger-advanced (or similar), when
there really isn't anything like that. What we have is
just additional functionality based on your OS flavor. So
keeping ginger as the plugin name, to me, is the easiest.
Then all it takes is looking up your flavor:
ginger-[ppc|z|pickled].</div>
<div><br>
</div>
</blockquote>
<br>
About the plugin name: does ginger-base sound better? As it
will the base for all the other ginger plugins which will
extend the Host tab.<br>
</blockquote>
<br>
'ginger-base' looks OK to me<br>
<br>
The other plug-in can be called simply 'ginger' in this case. <br>
<br>
<blockquote cite="mid:55CB373F.1050301@linux.vnet.ibm.com"
type="cite"> <br>
<blockquote
cite="mid:1439310445.3434.5.camel@linux.vnet.ibm.com"
type="cite">
<blockquote type="cite"> <br>
2) Create the new plugin structure into wok branch, ie,
create a directory named ginger-basic (?) and all it is
needed to launch it as a wok plugin, including building
and packaging details.<br>
In this first moment, the entire Host tab will be part
of the ginger-basic - just to move the discussion as soon
as possible to Ginger community.<br>
<br>
3) Add ginger-basic plugin as a Kimchi dependency.<br>
<br>
Once we have those items done, I will create a new
repository for ginger-basic under kimchi-project
organization in Github.<br>
After that, the discussion *will be moved to Ginger
community*, ie, all patches and discussion must be sent to
the Ginger mailing list (<a moz-do-not-send="true"
href="https://lists.nongnu.org/mailman/listinfo/ginger-dev-list"
style="box-sizing: border-box; color: rgb(64, 120, 192);
text-decoration: none; font-family: 'Helvetica Neue',
Helvetica, 'Segoe UI', Arial, freesans, sans-serif;
font-size: 16px; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal;
line-height: 20.4799995422363px; orphans: auto;
text-align: left; text-indent: 0px; text-transform:
none; white-space: normal; widows: 1; word-spacing: 0px;
-webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);">https://lists.nongnu.org/mailman/listinfo/ginger-dev-list</a><span
style="color: rgb(51, 51, 51); font-family: 'Helvetica
Neue', Helvetica, 'Segoe UI', Arial, freesans,
sans-serif; font-size: 16px; font-style: normal;
font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 20.4799995422363px;
orphans: auto; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: 1;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
display: inline !important; float: none;
background-color: rgb(255, 255, 255);"><span
class="Apple-converted-space"></span></span>)<br>
<br>
I have sent to Ginger community the next steps to be done
there. Please, check: "[Ginger-dev-list] [RFC] Inheriting
Kimchi's Host tab"<br>
<br>
Let me know what you think about that.<br>
<br>
Regards,<br>
Aline Manera<br>
<br>
<br>
<pre>_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>