<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Please, don't forget to reply to the Kimchi ML<br>
<br>
<div class="moz-cite-prefix">On 15/10/2015 09:43, Samuel Henrique De
Oliveira Guimaraes wrote:<br>
</div>
<blockquote
cite="mid:ae990a6ab3664e11be98dd44f20ecda4@serv030.corp.eldorado.org.br"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0B6CDA;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#551A8B;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 3.0cm 70.85pt 3.0cm;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Hi
Atreye,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"
lang="EN-US">Thank you! It works! I’ll rebase my patches and
once Aline applies the new-ui in Kimchi master, I’ll be
creating an issue for documentation purposes and you can
comment that you fixed and send a patch with the issue
number to the Mailing List, making your contribution appear
in the commit history.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"
lang="EN-US">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"
lang="EN-US">Samuel<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"
lang="EN-US">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"
lang="EN-US"> Atreye Mukhopadhyay
[<a class="moz-txt-link-freetext" href="mailto:atreyee@linux.vnet.ibm.com">mailto:atreyee@linux.vnet.ibm.com</a>]
<br>
<b>Sent:</b> quinta-feira, 15 de outubro de 2015 09:28<br>
<b>To:</b> Samuel Henrique De Oliveira Guimaraes
<a class="moz-txt-link-rfc2396E" href="mailto:samuel.guimaraes@eldorado.org.br"><samuel.guimaraes@eldorado.org.br></a><br>
<b>Cc:</b> Aline Manera
<a class="moz-txt-link-rfc2396E" href="mailto:alinefm@linux.vnet.ibm.com"><alinefm@linux.vnet.ibm.com></a>; Chandra Shehkhar
Reddy Potula <a class="moz-txt-link-rfc2396E" href="mailto:chandra@linux.vnet.ibm.com"><chandra@linux.vnet.ibm.com></a>; Walter
Niklaus <a class="moz-txt-link-rfc2396E" href="mailto:niklaus@linux.vnet.ibm.com"><niklaus@linux.vnet.ibm.com></a><br>
<b>Subject:</b> Fix for the repository action issue<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Samuel,<br>
I have fixed the issue you mentioned during the hangout
meeting session regarding the incorrect action name for
enabled repositories in repository list.<br>
I worked on the latest code available in your branch <a
moz-do-not-send="true"
href="https://github.com/samhenri/kimchi.git">
<span lang="EN-US">https://github.com/samhenri/kimchi.git</span></a><span
lang="EN-US"> . I have made changes in "</span>onRowSelected"
method in kimchi.host.js. Changes are highlighted below.<br>
<br>
Enable/disable button of each row was having same 'id' .
Incorrect action was displayed for the enabled repositories
other than first record as
$('#repositories-grid-enable-button') was always returning
button from first action dropdown menu.<br>
<br>
<br>
onRowSelected: function(row) {<br>
var repository =
repositoriesGrid.getSelected();<br>
if (!repository) {<br>
return;<br>
}<br>
<b> var selectedRow = $('tr',
repositoriesGrid.bodyContainer);</b><br>
$('#repositories-grid-remove-button',selectedRow).prop('disabled',
false);<br>
$('#repositories-grid-edit-button',selectedRow).prop('disabled',
false);<br>
var enabled = repository['enabled'];<br>
<br>
<b>$('#repositories-grid-enable-button',selectedRow)<br>
.html('<i class="fa
fa-play-circle-o"></i>'+</b>i18n[enabled ?
'KCHREPO6017M' : 'KCHREPO6016M'])<br>
.prop('disabled', false);<br>
},<br>
<br>
Screenshots are attached herewith.<br>
<br>
Please ignore the mail if you have resolved the issue already
.<br>
<br>
Thanks & Regards,<br>
Atreyee<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>