<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 16/11/2015 13:47, Walter Niklaus
wrote:<br>
</div>
<blockquote cite="mid:5649FA85.5040509@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Aline, the snapshots you have taken and the problems you
described make me suspect that the scss changes didn't really
make it into the css files. <br>
Atreyee struggled last week with this issue till Samuel pointed
out that she may have to delete the css files before issuing the
make. <br>
Chandra adressed this problem in Issue #757 and I think that patch
is available in the meantime. <br>
</blockquote>
<br>
Whew! I will test again tomorrow.<br>
<br>
But I still believe some of my comments applies.<br>
<br>
<blockquote cite="mid:5649FA85.5040509@linux.vnet.ibm.com"
type="cite"> <br>
<div class="moz-cite-prefix">On 16.11.2015 15:28, Aline Manera
wrote:<br>
</div>
<blockquote cite="mid:5649E822.3080407@linux.vnet.ibm.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Hi Atreyee,<br>
<br>
My overall comments:<br>
<br>
1) The "Host"/"Virtualization" tabs are not being displayed as a
Tab.<br>
You need to its background and also the first level second
level tab. It is the same on imaging the blue squares in the
image below filled with blue color. (does that make sense?)<br>
To distinguish a selected tab in the second level we can use
a darker color, ie, a darker blue (for ginger) or a darker green
(for kimchi).<br>
<br>
2) The first and the seconds level of tabs will have the same
color. For Kimchi, we continue to have one different color per
tab which is odd IMO.<br>
<br>
3) I'd suggest to align the "localhost" text with the first tab
in the second level. So the "Host" tab will be left shifted to
have the "Host" text aligned with "localhost".<br>
The same for Kimchi. You can check the red lines in the
images below.<br>
<br>
4) More comments in the patch related to the code.<br>
<br>
<img src="cid:part1.07050108.07020905@linux.vnet.ibm.com" alt=""><br>
<img src="cid:part2.09020304.08050004@linux.vnet.ibm.com" alt=""><br>
<br>
<div class="moz-cite-prefix">On 11/11/2015 20:34, <a
moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:atreyee@linux.vnet.ibm.com"><a class="moz-txt-link-abbreviated" href="mailto:atreyee@linux.vnet.ibm.com">atreyee@linux.vnet.ibm.com</a></a>
wrote:<br>
</div>
<blockquote
cite="mid:1447281287-2042-1-git-send-email-atreyee@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Atreyee Mukhopadhyay <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:atreyee@linux.vnet.ibm.com"><atreyee@linux.vnet.ibm.com></a>
This patch is to implement new feature mentioned in issue #746.
First level navigation bar with Host and Virtualization tabs.
Second level tab navigation based on first level navigation.
Atreyee Mukhopadhyay (1):
Issue #746 : New navigation bar.
src/wok/plugins/gingerbase/ui/config/tab-ext.xml | 1 +
src/wok/plugins/kimchi/ui/config/tab-ext.xml | 1 +
ui/css/src/modules/_toolbar.scss | 9 ++-
ui/css/src/modules/_wok-variables.scss | 7 +-
ui/js/src/wok.main.js | 81 +++++++++++++++++++++---
ui/pages/wok-ui.html.tmpl | 6 +-
6 files changed, 91 insertions(+), 14 deletions(-)
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>