<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
Hi Suresh,<br>
<br>
The patch looks good but there is a test failing due those changes.
Could you, please, fix it and resend?<br>
<br>
======================================================================<br>
FAIL: test_hostinfo (test_host.HostTests)<br>
----------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "test_host.py", line 77, in test_hostinfo<br>
self.assertEquals(psutil.TOTAL_PHYMEM, info['memory'])<br>
AssertionError: 8048709632L != {u'offline': 0, u'online':
8048709632}<br>
<br>
----------------------------------------------------------------------<br>
<br>
You also need to update the UI code to display the right value for
memory and CPUs.<br>
With this patch it is current displaying [object Object].<br>
<br>
<img src="cid:part1.02080202.07070806@linux.vnet.ibm.com" alt=""><br>
<br>
<div class="moz-cite-prefix">On 24/11/2015 09:59,
<a class="moz-txt-link-abbreviated" href="mailto:sureshab@linux.vnet.ibm.com">sureshab@linux.vnet.ibm.com</a> wrote:<br>
</div>
<blockquote
cite="mid:1448366384-20174-1-git-send-email-sureshab@linux.vnet.ibm.com"
type="cite">
<pre wrap="">From: Suresh Babu Angadi <a class="moz-txt-link-rfc2396E" href="mailto:sureshab@in.ibm.com"><sureshab@in.ibm.com></a>
V1 to V2 changes:
Changed cpus and memory object to be same across all platforms(aline)
Changed API.md and lookup as per review comments(aline & abhiram)
As per RFC mail thread -
[Kimchi-devel] RFC - #728 - Processor Info in s390 architecture
this patch set adds functionality in back-end to add
architecture, and host name(for all architecture),
split CPUs to online and offline(x86, s390x),
additional virtualization details(for s390x)
Note: Subsequent patch set for UI changes will follow
to accommodate these changes
Test Cases Executed:
====================
1) On x86 machine(ppc o/p will be similar to x86):
curl -k -u suresh -H "Content-Type: application/json" -H "Accept: application/json" -X GET '<a class="moz-txt-link-freetext" href="https://127.0.0.1:8001/plugins/gingerbase/host">https://127.0.0.1:8001/plugins/gingerbase/host</a>'
{
"os_distro":"Fedora",
"cpus":{
"offline":0,
"online":4
},
"cpu_model":"Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz",
"os_version":"21",
"host":"localhost.localdomain",
"os_codename":"Twenty One",
"architecture":"x86_64",
"memory":{
"offline":0,
"online":7933902848
}
}
2) On s390x machine:
curl -k -u root -H "Content-Type: application/json" -H "Accept: application/json" -X GET '<a class="moz-txt-link-freetext" href="https://127.0.0.1:8001/plugins/gingerbase/host">https://127.0.0.1:8001/plugins/gingerbase/host</a>'
{
"os_distro":"KVM for IBM z Systems",
"cpus":{
"shared":2,
"offline":2,
"dedicated":0,
"online":2
},
"cpu_model":"IBM/2827/743 H43",
"os_version":"1.1.1",
"host":"zfwcec103",
"os_codename":"Z",
"architecture":"s390x",
"memory":{
"offline":2147483648,
"online":2147483648
},
"virtualization":{
"lpar_name":"CSTLIN1",
"hypervisor":"PR/SM",
"lpar_number":55,
"hypervisor_vendor":"IBM"
}
}
Suresh Babu Angadi (1):
Fix for issue 728: processor info displays blank for system z
this patch set also adds additional capability:
retrieving architecture and host name (for all architecture)
split CPUs to show online and offline cpus also
includes shared and dedicated cpus for s390x
split memory to show online and offline
additional virtualization details(for s390x):
virtualization will have hypervisor details and lpar details
src/wok/plugins/gingerbase/docs/API.md | 18 +-
src/wok/plugins/gingerbase/i18n.py | 1 +
src/wok/plugins/gingerbase/lscpu.py | 60 ++++++
src/wok/plugins/gingerbase/model/host.py | 259 ++++++++++++++++++++++----
src/wok/plugins/gingerbase/tests/test_host.py | 12 +-
5 files changed, 307 insertions(+), 43 deletions(-)
</pre>
</blockquote>
<br>
</body>
</html>