<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 26/11/2015 10:18, Samuel Guimarães
wrote:<br>
</div>
<blockquote
cite="mid:CAKr4H-r=2cakT8F4L-+Rfr2-B7_pxo8XeDUdq39J0E3WEgFxMA@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-11-25 22:08 GMT-02:00 Aline
Manera <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:alinefm@linux.vnet.ibm.com" target="_blank">alinefm@linux.vnet.ibm.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class=""> <br>
<br>
<div>On 25/11/2015 22:06, Aline Manera wrote:<br>
</div>
<blockquote type="cite"> <br>
The filter in the guest tab is not working too.<br>
<br>
</blockquote>
<br>
</span> The filter is not working in the Templates tab
too.</div>
</blockquote>
<div><br>
</div>
<div>The filters are not working because they are just
placeholders. We can hide them for now and implement the
filter function as bugfix or in the next release because
unlike Storages and Networks that uses a jQuery-UI widget
for table creation (that has access to all jQuery UI
methos), Templates and Guests are plain HTML lists
manipulated by JavaScript. I believe it is not difficult
to do that in Templates but as for Guests it implies that
we should stop the VM stats refresh then filter and later
on new stat refresh we would have to keep track of the
list position. Right now on each stat refresh the whole
list is rebuilt in the DOM. We also have to add the
sortable filter in the gallery view:</div>
</div>
</div>
</div>
</blockquote>
<br>
OK. Let treat the filter as an issue and fix it after getting the
new UI upstream.<br>
<br>
<blockquote
cite="mid:CAKr4H-r=2cakT8F4L-+Rfr2-B7_pxo8XeDUdq39J0E3WEgFxMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div><img
src="cid:part2.05080300.03030009@linux.vnet.ibm.com"
height="373" width="423"></div>
<div><br>
</div>
<div>I think for the sortable we don't need to adjust
anything in the backend, jQuery-UI can reorder the ajax
response but that means we would have to rewrite the
Guests Lists into a Sortable widget (<a
moz-do-not-send="true"
href="https://jqueryui.com/sortable/"><a class="moz-txt-link-freetext" href="https://jqueryui.com/sortable/">https://jqueryui.com/sortable/</a></a>).
It is not difficult but consumes a lot of time.<br>
</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>
<div class="h5"><br>
<br>
<blockquote type="cite">
<div>On 25/11/2015 22:03, Aline Manera wrote:<br>
</div>
<blockquote type="cite"> <br>
Hi Samuel,<br>
<br>
Seems the columns are not aligned with the
headers:<br>
<br>
<img
src="cid:part4.05030002.00050900@linux.vnet.ibm.com"
alt=""><br>
<br>
Please, replace "Virtual Network Console" to
"Console".<br>
<br>
Also the statistic related to memory is about
memory utilization instead of memory available.
So change "Memory Available" to "Memory
utilization" or "Memory used"<br>
<br>
It would be good to allow user select the "power
on/off" icon to start/stop the guest too. But we
can do that after getting the new UI upstream.<br>
<br>
Regards,<br>
Aline Manera<br>
</blockquote>
</blockquote>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>This is the desgin spec:</div>
<div><br>
</div>
<div><img
src="cid:part5.01030405.00030203@linux.vnet.ibm.com"
style="margin-right: 0px;"></div>
<div><br>
</div>
<div>And this is the current version:</div>
<div><br>
</div>
<div><img
src="cid:part6.03090106.05010507@linux.vnet.ibm.com"
style="margin-right: 0px;"><br>
<br>
In this version we don't support sorting, so that's why we
don't have the arrow-up and arrow-down icons on the table
headers. Here the horizontal alignment is ok. The vertical
alignment is weird but we followed the mock-ups. I'll
change Virtual Network Console to VNC and the Memory
Available to Memory Utilization.</div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Thanks!<br>
<br>
<blockquote
cite="mid:CAKr4H-r=2cakT8F4L-+Rfr2-B7_pxo8XeDUdq39J0E3WEgFxMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>Regarding the icons, I agree this can be done after
this page is upstream because this wasn't listed as
requirement in the design specs. <br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Yeap! It is a suggestion! We don't need to have it now.<br>
<br>
<blockquote
cite="mid:CAKr4H-r=2cakT8F4L-+Rfr2-B7_pxo8XeDUdq39J0E3WEgFxMA@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>
<div class="h5">
<blockquote type="cite">
<blockquote type="cite"> <br>
<div>On 25/11/2015 19:25, <a
moz-do-not-send="true"
href="mailto:sguimaraes943@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:sguimaraes943@gmail.com">sguimaraes943@gmail.com</a></a>
wrote:<br>
</div>
<blockquote type="cite">
<pre>From: samhenri <a moz-do-not-send="true" href="mailto:samuel.guimaraes@eldorado.org.br" target="_blank"><samuel.guimaraes@eldorado.org.br></a>
This patch adds new-ui to Guests page and some styles for new-ui in Ginger.
Andre Teodoro (1):
[new-ui] Adding new-ui to Administration tab
* If applied may break some jQuery-UI collapsible elements
samhenri (2):
Minor CSS fixes in the new-ui
[new-ui] Guests tab
.../plugins/kimchi/ui/css/theme-default/list.css | 330 ----------
.../plugins/kimchi/ui/js/src/kimchi.guest_main.js | 676 +++++++++++++--------
src/wok/plugins/kimchi/ui/pages/guest.html.tmpl | 125 ++--
src/wok/plugins/kimchi/ui/pages/guests.html.tmpl | 33 +-
ui/css/src/modules/_administration.scss | 340 +++++++++++
ui/css/src/modules/_guests.scss | 241 ++++++++
ui/css/src/modules/_network.scss | 2 +-
ui/css/src/modules/_storage.scss | 2 +-
ui/css/src/modules/_wok-grid.scss | 2 +-
ui/css/src/modules/_wok-variables.scss | 9 +-
ui/images/theme-default/icon-unknown.png | Bin 761 -> 3797 bytes
11 files changed, 1115 insertions(+), 645 deletions(-)
delete mode 100644 src/wok/plugins/kimchi/ui/css/theme-default/list.css
</pre>
</blockquote>
<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Kimchi-devel mailing list
<a moz-do-not-send="true" href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a>
<a moz-do-not-send="true" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</body>
</html>