<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2016-01-11 14:29 GMT-02:00 Rodrigo Trujillo <span dir="ltr"><<a href="mailto:rodrigo.trujillo@linux.vnet.ibm.com" target="_blank">rodrigo.trujillo@linux.vnet.ibm.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class="">
<br>
<div>On 01/11/2016 12:56 PM, Samuel
Guimarães wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi team,
<div><br>
</div>
<div>I have some questions. I've wrote them below the
requirements for the front-end.</div>
<div><br>
</div>
<div>Samuel</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-01-08 16:18 GMT-02:00 Rodrigo
Trujillo <span dir="ltr"><<a href="mailto:rodrigo.trujillo@linux.vnet.ibm.com" target="_blank">rodrigo.trujillo@linux.vnet.ibm.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi
all,<br>
<br>
The guest xml tag <max_memory> is necessary to allow
memory hotplug. Currently, max_memory is the lesser value
among "guest memory X4", "Host Memory" or "1TB". It is
also not possible to user, to set it.<br>
<br>
Proposal: Modify backend and frontend in order to allow
users to increase/decrease max_memory value. In other
words, user will be allowed to set the amount of memory
that will be possible to hotplug.<br>
<br>
BACKEND (a previous patch was already sent to mailing
list, must sent new version)<br>
- Remove current settings when guest is created. Set
max_memory equal guest memory.;<br>
- Does not allow change max_memory when guest is running;<br>
- When hotplug, continue with slots of 1GB, but restrict
32 slots in PowerPC;<br>
- Update/Add tests;<br>
- Change JSON memory field to: memory: { current: XXX,
maxmemory: YYYY };<br>
<br>
<br>
FRONTEND<br>
<br>
- In guest edit window, modify memory input field. Change
it to a increase/decrease ( +/- ) input box;<br>
</blockquote>
<div><br>
</div>
<div>IE9, 10, 11 and Edge doesn't fully support input
"number" yet. They display as a regular text field with a
"x" to clear the field and accept only numbers but they
don't show the double arrows (that we can't change to +
and - even in Chrome). If we all agree I'm ok to change
the input type from text to number regardless of these
known issues.</div>
</div>
</div>
</div>
</blockquote></span>
I am ok with this.<span class=""><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">-
Create a hidden area which will hold max memory input box
(increase/decrease);<br>
</blockquote>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">-
Increments will be of 1GB;<br>
</blockquote>
<div><br>
</div>
<div>Is this increment rule only for the Max Memory input or
also for the current memory? What happens If the user
start editing a VM that was created outside Kimchi and has
set the maximum memory to something like 768MB? Should the
input fill the memory to 1024MB and then on the next click
in the arrow go to 2048MB or add 1024MB on top of the
current memory?</div>
<div> </div>
</div>
</div>
</div>
</blockquote></span>
Both memories.<br>
For machines created outside Kimchi, or even in Kimchi command
line... always show the saved value... then when user increase or
decrease, round it to next GB value. <br></div></blockquote><div><br></div><div>Ok! This can be done with the "step" attribute in the input number (which is supported by IE). I think we should get the step value by the back-end and change the attribute by JS in case we have a specific machine that supports more than 1GB.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><span class="">
<br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">-
Create a "More Options" link besides Memory , that is
going to show/hide max memory area;<br>
- If guest is online:<br>
* max memory field will be disabled;<br>
* memory will be enabled, allowing hotplug;<br>
- When guest is offline, it is ok to change max memory,
enable it;<br>
<br>
<br>
API CHANGES:<br>
<br>
JSON must be changed in requests and responses:<br>
- When updating guest (PUT), memory field will become:<br>
memory: { current: <memory new value>,
maxmemory: <maxmemory new value> }<br>
- response (GET):<br>
memory: { current: <memory new value>,
maxmemory: <maxmemory new value> }<br>
<br>
It is not necessary to include maxmemory if was not
changed.<br>
<br>
Thoughts ?<br>
<br>
Rodrigo Trujillo<br>
<br>
_______________________________________________<br>
Kimchi-devel mailing list<br>
<a href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a><br>
</blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Kimchi-devel mailing list
<a href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</span></div>
<br>_______________________________________________<br>
Kimchi-devel mailing list<br>
<a href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a><br>
<br></blockquote></div><br></div></div>