<div dir="ltr">Aline,<div><br></div><div>Even when the VLAN checkbox is not selected, the backend is validating the VLAN ID field. If the VLAN ID is required for bridged with nic or bonding interface, I don't see a reason for a checkbox in the UI.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-02-05 15:36 GMT-02:00 Aline Manera <span dir="ltr"><<a href="mailto:alinefm@linux.vnet.ibm.com" target="_blank">alinefm@linux.vnet.ibm.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class="">
<br>
<br>
<div>On 02/05/2016 03:12 PM, Peter Pennings
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi
<div><br>
</div>
<div>I'm working on a V2 patch for this issue and I have one
doubt. </div>
<div>Now, I'm showing the VLAN option when a bridged is selected
with a NIC or bonding interface. In this case, the VLAN ID is
required or can be empty? I guess backend is validating this
and turned this field obrigatory.</div>
<div><br>
</div>
</div>
</blockquote>
<br></span>
When VLAN is selected, a VLAN tag is required.<div><div class="h5"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div>Thanks</div>
<div><br>
</div>
<div>Peter</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-02-05 10:01 GMT-02:00 Aline Manera
<span dir="ltr"><<a href="mailto:alinefm@linux.vnet.ibm.com" target="_blank">alinefm@linux.vnet.ibm.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <br>
Hi Peter,<br>
<br>
Even selecting a NIC interface, the VLAN option is not
being displayed for a Bridged network.<br>
<br>
You can try it by yourself too.
<div>
<div><br>
<br>
<div>On 02/05/2016 09:18 AM, Peter Pennings wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">I followed bellow specifications, the
VLAN form should be showed when a NIC or bonding
is selected. Is that not being showed?
<div><br>
</div>
<div><a href="https://github.com/kimchi-project/kimchi/issues/791" target="_blank">https://github.com/kimchi-project/kimchi/issues/791</a><br>
<div><br>
</div>
<div>
<p><font color="#cc0000"><b>Bridged option new
behaviour:</b></font><br>
<font color="#333333">1) Change description
of "Bridged" option to refer to Linux
bridges and OVS bridges (no more direct
connections)</font><br>
<font color="#333333">2) When "Bridged" is
selected, "Destination" will show all the
interfaces it currently shows plus OVS
bridges</font><br>
<b style="color:rgb(51,51,51)">3) "Enable
VLAN" will only be showed if user selects
a NIC or bonding from "Destination" pop-up</b><font color="#333333"> (alternatively, we can
show it always and block the usage of VLAN
with NIC or bonding selected)</font><br>
<font color="#333333">4) "Bridged" option
will call network_create API with "bridge"
as value for "connection" parameter</font></p>
<p><font color="#cc0000"><b>New macvtap
option:</b></font><br>
<font color="#333333">5) Add a new option
"macvtap" to Network Type, with same
current description of today's Bridged
option</font><br>
<font color="#333333">6) When macvtap option
is selected, "Destination" will show only
NICs and bondings. It will NOT show any
kind of bridges anymore.</font><br>
<b style="color:rgb(51,51,51)">7) "Enable
VLAN" option is NOT showed</b><br>
<font color="#333333">8) macvtap option will
call network create API with "macvtap" as
"connection" parameter value.</font></p>
<p><font color="#333333"><br>
</font></p>
<p><font color="#333333">I will send a V2
patch with the others corrections
(function name and alert messages). If V1
patch is not according with the above
specifications, please, let me know, then
I can fix it.</font></p>
<p><font color="#333333"><br>
</font></p>
<p><font color="#333333">Thanks</font></p>
<p><font color="#333333"><br>
</font></p>
<p><font color="#333333">Peter </font></p>
</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-02-04 16:50
GMT-02:00 Lucio Correia <span dir="ltr"><<a href="mailto:luciojhc@linux.vnet.ibm.com" target="_blank"></a><a href="mailto:luciojhc@linux.vnet.ibm.com" target="_blank">luciojhc@linux.vnet.ibm.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 04-02-2016
15:38, Lucio Correia wrote:<br>
</span><span>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I will run
some tests now with this and send more
comments afterwards.<br>
Here are my review comments. Additional
comments in the code.<br>
</blockquote>
<br>
</span> The only problem I noticed is that
VLAN form is not being showed when I select
Linux and OVS bridges.
<div>
<div><br>
<br>
-- <br>
Lucio Correia<br>
Software Engineer<br>
IBM LTC Brazil<br>
<br>
_______________________________________________<br>
Kimchi-devel mailing list<br>
<a href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
Kimchi-devel mailing list
<a href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>