<div dir="ltr">I followed bellow specifications, the VLAN form should be showed when a NIC or bonding is selected. Is that not being showed?<div><br></div><div><a href="https://github.com/kimchi-project/kimchi/issues/791">https://github.com/kimchi-project/kimchi/issues/791</a><br><div><br></div><div><p style="margin-top:0px;margin-bottom:16px;font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:22.4px"><font color="#cc0000"><b>Bridged option new behaviour:</b></font><br><font color="#333333">1) Change description of "Bridged" option to refer to Linux bridges and OVS bridges (no more direct connections)</font><br><font color="#333333">2) When "Bridged" is selected, "Destination" will show all the interfaces it currently shows plus OVS bridges</font><br><b style="color:rgb(51,51,51)">3) "Enable VLAN" will only be showed if user selects a NIC or bonding from "Destination" pop-up</b><font color="#333333"> (alternatively, we can show it always and block the usage of VLAN with NIC or bonding selected)</font><br><font color="#333333">4) "Bridged" option will call network_create API with "bridge" as value for "connection" parameter</font></p><p style="margin-top:0px;font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important"><font color="#cc0000"><b>New macvtap option:</b></font><br><font color="#333333">5) Add a new option "macvtap" to Network Type, with same current description of today's Bridged option</font><br><font color="#333333">6) When macvtap option is selected, "Destination" will show only NICs and bondings. It will NOT show any kind of bridges anymore.</font><br><b style="color:rgb(51,51,51)">7) "Enable VLAN" option is NOT showed</b><br><font color="#333333">8) macvtap option will call network create API with "macvtap" as "connection" parameter value.</font></p><p style="margin-top:0px;font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important"><font color="#333333"><br></font></p><p style="margin-top:0px;font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important"><font color="#333333">I will send a V2 patch with the others corrections (function name and alert messages). If V1 patch is not according with the above specifications, please, let me know, then I can fix it.</font></p><p style="margin-top:0px;font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important"><font color="#333333"><br></font></p><p style="margin-top:0px;font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important"><font color="#333333">Thanks</font></p><p style="margin-top:0px;font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important"><font color="#333333"><br></font></p><p style="margin-top:0px;font-family:'Helvetica Neue',Helvetica,'Segoe UI',Arial,freesans,sans-serif,'Apple Color Emoji','Segoe UI Emoji','Segoe UI Symbol';font-size:14px;line-height:22.4px;margin-bottom:0px!important"><font color="#333333">Peter </font></p></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-02-04 16:50 GMT-02:00 Lucio Correia <span dir="ltr"><<a href="mailto:luciojhc@linux.vnet.ibm.com" target="_blank">luciojhc@linux.vnet.ibm.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 04-02-2016 15:38, Lucio Correia wrote:<br>
</span><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I will run some tests now with this and send more comments afterwards.<br>
Here are my review comments. Additional comments in the code.<br>
</blockquote>
<br></span>
The only problem I noticed is that VLAN form is not being showed when I select Linux and OVS bridges.<div class="HOEnZb"><div class="h5"><br>
<br>
-- <br>
Lucio Correia<br>
Software Engineer<br>
IBM LTC Brazil<br>
<br>
_______________________________________________<br>
Kimchi-devel mailing list<br>
<a href="mailto:Kimchi-devel@ovirt.org" target="_blank">Kimchi-devel@ovirt.org</a><br>
<a href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel" rel="noreferrer" target="_blank">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a><br>
</div></div></blockquote></div><br></div>