<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
I don't think max memory and max CPUs values are too important to be
displayed on first view.<br>
<br>
I'd say to remove them when adding a guest instead of adding on
Templates galley view.<br>
<br>
<div class="moz-cite-prefix">On 03/11/2016 09:56 AM, Samuel Henrique
De Oliveira Guimaraes wrote:<br>
</div>
<blockquote
cite="mid:40507758cfc541a9a9feeaba8347aadc@serv031.corp.eldorado.org.br"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]-->
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 3.0cm 70.85pt 3.0cm;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"
lang="EN-US">Hi. I think the Templates should be updated to
look like Guests, including the Max Memory and Max CPU
labels.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Samuel<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"
lang="EN-US">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"
lang="EN-US"> <a class="moz-txt-link-abbreviated" href="mailto:kimchi-devel-bounces@ovirt.org">kimchi-devel-bounces@ovirt.org</a>
[<a class="moz-txt-link-freetext" href="mailto:kimchi-devel-bounces@ovirt.org">mailto:kimchi-devel-bounces@ovirt.org</a>] <b>On Behalf Of
</b>Socorro Stoppler<br>
<b>Sent:</b> quarta-feira, 9 de março de 2016 20:49<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:sguimaraes943@gmail.com">sguimaraes943@gmail.com</a>; Kimchi Devel
<a class="moz-txt-link-rfc2396E" href="mailto:kimchi-devel@ovirt.org"><kimchi-devel@ovirt.org></a><br>
<b>Subject:</b> Re: [Kimchi-devel] [PATCH] [Kimchi]
Fixed Memory and Max Memory values when adding a new
Guest<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Regarding my
question below about CPUs, should it look like this?
<br>
<br>
(From adding a guest)<br>
<br>
<img id="_x0000_i1025"
src="cid:part1.04040108.07060100@linux.vnet.ibm.com"
height="388" width="272"><br>
<br>
A couple more observations:<br>
1. Above has the units displayed without a space to the right
of the #. But in Templates tab (regardless of the view), it
has a space as such below.
<br>
Shouldn't they be consistent?<br>
<br>
2. Does it make sense here to show the max for CPU and Memory
for Templates?<br>
<br>
(Gallery view of Templates)<br>
<br>
<img id="_x0000_i1026"
src="cid:part2.09030107.07000200@linux.vnet.ibm.com"
height="391" width="252"><br>
<br>
Thanks<br>
-Socorro<o:p></o:p></p>
<div>
<p class="MsoNormal">On 03/09/2016 02:24 PM, Socorro Stoppler
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Reviewed-by: Socorro Stoppler <a
moz-do-not-send="true"
href="mailto:socorro@linux.vnet.ibm.com">
<a class="moz-txt-link-rfc2396E" href="mailto:socorro@linux.vnet.ibm.com"><socorro@linux.vnet.ibm.com></a></a> <br>
Tested-by: Socorro Stoppler <a moz-do-not-send="true"
href="mailto:socorro@linux.vnet.ibm.com"><socorro@linux.vnet.ibm.com></a>
<br>
<br>
Question: should CPU be also shown the same way? <br>
<br>
On 03/09/2016 01:55 PM, <a moz-do-not-send="true"
href="mailto:sguimaraes943@gmail.com">sguimaraes943@gmail.com</a>
wrote:
<br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">From: Samuel Guimarães <a
moz-do-not-send="true"
href="mailto:sguimaraes943@gmail.com">
<a class="moz-txt-link-rfc2396E" href="mailto:sguimaraes943@gmail.com"><sguimaraes943@gmail.com></a></a> <br>
<br>
Signed-off-by: Samuel Guimarães <a moz-do-not-send="true"
href="mailto:sguimaraes943@gmail.com"><sguimaraes943@gmail.com></a>
<br>
--- <br>
ui/pages/guest-add.html.tmpl | 8 +++++--- <br>
1 file changed, 5 insertions(+), 3 deletions(-) <br>
<br>
diff --git a/ui/pages/guest-add.html.tmpl
b/ui/pages/guest-add.html.tmpl <br>
index a531af2..57f187e 100644 <br>
--- a/ui/pages/guest-add.html.tmpl <br>
+++ b/ui/pages/guest-add.html.tmpl <br>
@@ -59,13 +59,15 @@ <br>
<h3 class="iso-title {os_distro}"
title="{name}">{name}</h3>
<br>
<dl class="iso-info"> <br>
<dt>{os_distro}</dt>
<br>
-
<dd>$_("OS: ")</dd> <br>
+
<dd>$_("OS")</dd> <br>
<dt>{os_version}</dt>
<br>
-
<dd>$_("Version: ")</dd>
<br>
+
<dd>$_("Version")</dd>
<br>
<dt>{cpus}</dt> <br>
<dd>$_("CPUS")</dd>
<br>
-
<dt>{memory}M</dt> <br>
+
<dt>{memory.current}M</dt>
<br>
<dd>$_("Memory")</dd>
<br>
+
<dt>{memory.maxmemory}M</dt>
<br>
+
<dd>$_("Max Memory")</dd>
<br>
</dl> <br>
</span> <br>
</span> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kimchi-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>