<div dir="ltr">Hi,<div><br></div><div>Like I've said before on Kimchi dev-list, specially regarding plugin development:</div><div><br></div><div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Sometimes when we change the SCSS files the CSS output will be exactly the same. I can't recall exactly when, but there were some occasions that I had to reorganize the SCSS files or remove a static color or font variable and then replaced it with a variable in _wok-variables.scss. <br>There's also the possibility that python-libsass is running different versions from distro to distro and generating different selectors, although this won't change anything in the CSS except for readability. For example:<br>#guest-edit-window #form-guest-edit-general #guest-edit-memory-textbox, #guest-edit-window #form-guest-edit-general #guest-show-max-memory, #guest-edit-window #form-guest-edit-general #guest-edit-cores-textbox, #guest-edit-window #form-guest-edit-general #guest-show-max-processor {<br> display: inline-block;<br>}<br>Sometimes is generated like this:<br>#guest-edit-window #form-guest-edit-general #guest-edit-memory-textbox, #guest-edit-window #form-guest-edit-general #guest-show-max-memory, #guest-edit-window #form-guest-edit-general #guest-edit-cores-textbox, #guest-edit-window #form-guest-edit-general #guest-show-max-processor {<br> display: inline-block;<br>}<br>I suggest we look for updates in Libsass (pip install --upgrade libsass) before running any major change in the CSS files to avoid this.</blockquote><div><br></div><div>Right now the only "gap" I see with Ginger is that the Typeahead CSS section used in Sysmodules is duplicated from wok.css. In these very rare occasions that a new widget is introduced due to a new feature in a plugin and then in the next release another feature in a different plugin has the same use case that requires this new widget, I suggest we send a patch to Wok adding the new SCSS / CSS and JS lines and after and only after these new styles and scripts are applied to Wok we remove them from Ginger (or any other plugin for that matter).</div><div><br></div><div>Regards,</div><div>Samuel</div><br>Em sexta-feira, 18 de março de 2016 08:21:10 UTC-3, Chandra Shekhar Reddy Potula escreveu:<blockquote class="gmail_quote" style="margin: 0;margin-left: 0.8ex;border-left: 1px #ccc solid;padding-left: 1ex;">Hi All,
<br>
<br>I see a gap between scss and css always in the upstream code. For sure
<br>during the development we always re-compile and get the latest style
<br>sheets.
<br>
<br>My suggestion would be whenever there is a change in the scss file's
<br>request to upstream, will it be good idea to ask developer who want scss
<br>changes to upstream push corresponding css file changes too ie
<br>re-compiled code ?
<br>
<br>This will some times eliminate the gap between the css and scss files,
<br>which I suppose mostly taken care by the maintainer at present ?
<br>
<br>Just a thought, let me know your views on this !!!
<br>
<br>
<br>Thanks and Regards
<br>Chandra
<br>
<br></blockquote></div></div>