<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 3.0cm 70.85pt 3.0cm;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="PT-BR" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">I don’t think the new login.html is good for accessibility with screen reader software. I don’t have the tools to test
it, but the form fields were added to a <dl> element (Definition list) when just the <form>, <label> and <input> elements should be enough for accessibility, usability and styling.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">From my experience with screen readers, the output from a screen reader would be something like this:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">-Definition List<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">-Definition term: Username.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">-Definition description: input type text Username.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">-Definition term: Password.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">-Definition description: input type password Password.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">-Definition term: Language.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">-Definition description: Select.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">-Selected option: English (US).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">If we move the Locale and display it under the <select> element, it should be done with CSS only. Personally, I think
it doesn’t look good. Instead I think we could align it in the middle, just like we do with the Log In button.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">I don’t think displaying the label and the select in a single line is good for mobile usability with the login page and
it doesn’t make sense to create a different login page for mobile and desktop just to move a label:
<a href="http://baymard.com/blog/mobile-form-usability-label-position">http://baymard.com/blog/mobile-form-usability-label-position</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US">Samuel<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> kimchi-devel-bounces@ovirt.org
[mailto:kimchi-devel-bounces@ovirt.org] <b>On Behalf Of </b>Aline Manera<br>
<b>Sent:</b> segunda-feira, 9 de maio de 2016 10:39<br>
<b>To:</b> pkulkark@linux.vnet.ibm.com; Kimchi Devel <kimchi-devel@ovirt.org><br>
<b>Subject:</b> Re: [Kimchi-devel] [Wok][PATCH v2 0/7] Multi-Culture Support<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span lang="EN-US">Hi all,<br>
<br>
I'd like suggest changes on UI layout.<br>
<br>
</span><img border="0" width="387" height="456" id="Picture_x0020_1" src="cid:image001.jpg@01D1AA0F.DEB41430" alt="cid:image001.jpg@01D1AA0F.DEB41430"><span lang="EN-US"><br>
I am not sure about the best practices to display language and locale to users but I will suggest to put:<br>
<br>
<label> <drop down menu> in a single line, instead of having the label under the drop down menu.<br>
<br>
Samuel, any suggestion on that area?<br>
<br>
Regards,<br>
Aline Manera<br>
<br>
<br>
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US">On 05/05/2016 04:02 AM, </span><a href="mailto:pkulkark@linux.vnet.ibm.com"><span lang="EN-US">pkulkark@linux.vnet.ibm.com</span></a><span lang="EN-US"> wrote:<o:p></o:p></span></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre><span lang="EN-US">From: Pooja Kulkarni </span><a href="mailto:pkulkark@linux.vnet.ibm.com"><span lang="EN-US"><pkulkark@linux.vnet.ibm.com></span></a><span lang="EN-US"><o:p></o:p></span></pre>
<pre><span lang="EN-US"><o:p> </o:p></span></pre>
<pre><span lang="EN-US">This patch set provides multi-culture<o:p></o:p></span></pre>
<pre><span lang="EN-US">support by adding another drop down<o:p></o:p></span></pre>
<pre><span lang="EN-US">list during login for user locale<o:p></o:p></span></pre>
<pre><span lang="EN-US">selection. The numeric data and datetime<o:p></o:p></span></pre>
<pre><span lang="EN-US">fields are formatted based on the locale<o:p></o:p></span></pre>
<pre><span lang="EN-US">selected.<o:p></o:p></span></pre>
<pre><span lang="EN-US"><o:p> </o:p></span></pre>
<pre><span lang="EN-US">Pooja Kulkarni (7):<o:p></o:p></span></pre>
<pre><span lang="EN-US"> Multi-Culture Support - Add a separate drop down list for locale<o:p></o:p></span></pre>
<pre><span lang="EN-US"> Multi-Culture support - Add methods to get and set locales in<o:p></o:p></span></pre>
<pre><span lang="EN-US"> wok.lang.js<o:p></o:p></span></pre>
<pre><span lang="EN-US"> Multi-Culture support - Add locale in format settings in<o:p></o:p></span></pre>
<pre><span lang="EN-US"> wok.line-chart.js<o:p></o:p></span></pre>
<pre><span lang="EN-US"> Multi-Culture support : Format datetime as per locale in wok.list.js<o:p></o:p></span></pre>
<pre><span lang="EN-US"> Multi-Culture support : Implement new drop down list for locale in<o:p></o:p></span></pre>
<pre><span lang="EN-US"> wok.login.js<o:p></o:p></span></pre>
<pre><span lang="EN-US"> Multi-Culture support : Modify wok.formatMeasurement util to include<o:p></o:p></span></pre>
<pre><span lang="EN-US"> formatting based on locale<o:p></o:p></span></pre>
<pre><span lang="EN-US"> Multi-Culture support : Format datetime in user activity log as per<o:p></o:p></span></pre>
<pre><span lang="EN-US"> locale<o:p></o:p></span></pre>
<pre><span lang="EN-US"><o:p> </o:p></span></pre>
<pre><span lang="EN-US"> ui/js/src/wok.lang.js | 8 ++++++++<o:p></o:p></span></pre>
<pre><span lang="EN-US"> ui/js/src/wok.line-chart.js | 3 ++-<o:p></o:p></span></pre>
<pre><span lang="EN-US"> ui/js/src/wok.list.js | 6 +++++-<o:p></o:p></span></pre>
<pre><span lang="EN-US"> ui/js/src/wok.login.js | 9 +++++++++<o:p></o:p></span></pre>
<pre><span lang="EN-US"> ui/js/src/wok.utils.js | 10 +++++++---<o:p></o:p></span></pre>
<pre><span lang="EN-US"> ui/js/wok.bootgrid.js | 10 +++++++++-<o:p></o:p></span></pre>
<pre><span lang="EN-US"> </span>ui/js/wok.user-log.js | 3 ++-<o:p></o:p></pre>
<pre> ui/pages/login.html.tmpl | 34 ++++++++++++++++++++++++++++++++++<o:p></o:p></pre>
<pre> 8 files changed, 76 insertions(+), 7 deletions(-)<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>