<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Samuel,<br>
<br>
Just one comment.<br>
The progress bar for a new volume is being displayed along the area
width as you can see in the image below<br>
<br>
<img src="cid:part1.B17CB0AA.11EA87A2@linux.vnet.ibm.com" alt=""><br>
<br>
<br>
Is that intentional?<br>
I'd suggest to move the progress bar with the "In Progress" label or
we can also remove it IMO as we already have the "In Progress"
label. Maybe only add the total size to the label like "In
Progress... 264.0MB/10GB'<br>
<br>
Also the unit should be MB, GB, KB, etc as it is for the volume
size. MiB, GiB and KiB are for transfer rate unit<br>
<br>
<div class="moz-cite-prefix">On 05/24/2016 04:51 PM,
<a class="moz-txt-link-abbreviated" href="mailto:sguimaraes943@gmail.com">sguimaraes943@gmail.com</a> wrote:<br>
</div>
<blockquote
cite="mid:1464119479-46438-1-git-send-email-sguimaraes943@gmail.com"
type="cite">
<pre wrap="">From: Samuel Guimarães <a class="moz-txt-link-rfc2396E" href="mailto:sguimaraes943@gmail.com"><sguimaraes943@gmail.com></a>
This patch adds Storage Volume management functions Wipe, Clone, Resize and Delete with multiple selection. It also includes a filter input for each Storage Pool and Gallery View for Storage Volumes.
v1:
- HTML and CSS
v2:
- Delete and Wipe with multi-selection
- Confirm messages with list of selected volumes when wiping or deleting volumes (requires SCSS/CSS patch sent to Wok)
- Filter working
- Removed "Add Volume" link from Storage Pool action button
- Added "Add Volume" to Volume box action button
v3:
- Clone function working with multiple selection
- Progress bar working for clone and create volume
- Temporary volume added to the volumes when cloning
- Seamless refresh on the volumes once each task is finished
- Fixed issue when list wouldn't refresh when all volumes are removed from the storage pool.
v4:
- Prevent scroll when Drop-down in volumes list is clicked
- Dropdown is not clipped from volumes list when there's only one or two items on the list
- Added Media Queries for small screen resolutions
v5:
- Fixed black border in Firefox and IE when switching from List View to Gallery View
- Allocation and % Used in the parent table are now updated when wiping/resizing/deleting/cloning volumes
- Removed success messages / duplicated messages
- Changed scrollbar position in Volumes area
- When applying multiple actions, the checkbox is hidden/disabled and a spinner is shown while the the queue of selected items is being processed
Samuel Guimarães (1):
Storage Volume management
model/storagevolumes.py | 2 +-
ui/css/kimchi.css | 396 +++++++++++++++--
ui/css/src/modules/_storage.scss | 375 ++++++++++++++--
ui/js/src/kimchi.api.js | 50 +++
ui/js/src/kimchi.storage_main.js | 488 +++++++++++++++++----
ui/js/src/kimchi.storagepool_add_volume_main.js | 2 +-
ui/js/src/kimchi.storagepool_resize_volume_main.js | 59 +++
ui/pages/i18n.json.tmpl | 4 +
ui/pages/storagepool-resize-volume.html.tmpl | 51 +++
ui/pages/tabs/storage.html.tmpl | 155 ++++---
10 files changed, 1323 insertions(+), 259 deletions(-)
create mode 100644 ui/js/src/kimchi.storagepool_resize_volume_main.js
create mode 100644 ui/pages/storagepool-resize-volume.html.tmpl
</pre>
</blockquote>
<br>
</body>
</html>