<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
I did a quick investigation and I noticed you are returning
'interfaces' for x86 when it should be s390x specific<br>
<br>
[u'cdrom', u'cpu_info', u'disks', u'folder', u'graphics', u'icon', <b>u'interfaces',</b>
u'invalid', u'memory', u'name', u'networks', u'os_distro',
u'os_version']<br>
['cdrom', 'cpu_info', 'disks', 'folder', 'graphics', 'icon',
'invalid', 'memory', 'name', 'networks', 'os_distro', 'os_version']<br>
<br>
<br>
<div class="moz-cite-prefix">On 09/01/2016 02:13 PM, Aline Manera
wrote:<br>
</div>
<blockquote
cite="mid:61493df3-506b-23e4-c0c6-ebbee9ab38ba@linux.vnet.ibm.com"
type="cite">Hi Archana,
<br>
<br>
The tests are failing on x86 with those patches:
<br>
<br>
***** Running unit test: test_template... FAILED
<br>
======================================================================
<br>
FAIL: test_tmpl_lifecycle (test_template.TemplateTests)
<br>
----------------------------------------------------------------------
<br>
Traceback (most recent call last):
<br>
File "test_template.py", line 113, in test_tmpl_lifecycle
<br>
self.assertEquals(sorted(tmpl.keys()), sorted(keys))
<br>
AssertionError: Lists differ: [u'cdrom', u'cpu_info', u'disk... !=
['cdrom', 'cpu_info', 'disks',...
<br>
<br>
First differing element 6:
<br>
interfaces
<br>
invalid
<br>
<br>
First list contains 1 additional elements.
<br>
First extra element 12:
<br>
os_version
<br>
<br>
- [u'cdrom',
<br>
? -
<br>
<br>
+ ['cdrom',
<br>
- u'cpu_info',
<br>
? -
<br>
<br>
+ 'cpu_info',
<br>
- u'disks',
<br>
? -
<br>
<br>
+ 'disks',
<br>
- u'folder',
<br>
? -
<br>
<br>
+ 'folder',
<br>
- u'graphics',
<br>
? -
<br>
<br>
+ 'graphics',
<br>
- u'icon',
<br>
? -
<br>
<br>
+ 'icon',
<br>
- u'interfaces',
<br>
- u'invalid',
<br>
? -
<br>
<br>
+ 'invalid',
<br>
- u'memory',
<br>
? -
<br>
<br>
+ 'memory',
<br>
- u'name',
<br>
? -
<br>
<br>
+ 'name',
<br>
- u'networks',
<br>
? -
<br>
<br>
+ 'networks',
<br>
- u'os_distro',
<br>
? -
<br>
<br>
+ 'os_distro',
<br>
- u'os_version']
<br>
? -
<br>
<br>
+ 'os_version']
<br>
<br>
----------------------------------------------------------------------
<br>
Ran 5 tests in 20.021s
<br>
<br>
FAILED (failures=1)
<br>
<br>
<br>
Could you verify that and resend the patches?
<br>
<br>
Thanks,
<br>
Aline Manera
<br>
<br>
On 09/01/2016 12:35 PM, <a class="moz-txt-link-abbreviated" href="mailto:archus@linux.vnet.ibm.com">archus@linux.vnet.ibm.com</a> wrote:
<br>
<blockquote type="cite">From: Archana Singh
<a class="moz-txt-link-rfc2396E" href="mailto:archus@linux.vnet.ibm.com"><archus@linux.vnet.ibm.com></a>
<br>
<br>
1) Code changes for additional param 'interfaces' to template
API.
<br>
2) API.md changes for same.
<br>
<br>
Archana Singh (2):
<br>
Updated code to support 'interfaces' parameter to template
API only on
<br>
s390x/s390 architecture.
<br>
Updated API.md for addition interfaces paramter in template
API.
<br>
<br>
API.json | 41 ++++++++++++++++++++++++++++++-
<br>
control/templates.py | 1 +
<br>
docs/API.md | 12 +++++++++
<br>
i18n.py | 6 +++++
<br>
model/templates.py | 17 +++++++++++++
<br>
osinfo.py | 5 ++--
<br>
vmtemplate.py | 20 +++++++++++++++
<br>
xmlutils/interface.py | 67
+++++++++++++++++++++++++++++++++++++++++++++++++++
<br>
8 files changed, 166 insertions(+), 3 deletions(-)
<br>
<br>
</blockquote>
<br>
_______________________________________________
<br>
Kimchi-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Kimchi-devel@ovirt.org">Kimchi-devel@ovirt.org</a>
<br>
<a class="moz-txt-link-freetext" href="http://lists.ovirt.org/mailman/listinfo/kimchi-devel">http://lists.ovirt.org/mailman/listinfo/kimchi-devel</a>
<br>
<br>
</blockquote>
<br>
</body>
</html>